Code Monkey home page Code Monkey logo

Comments (3)

jacobedawson avatar jacobedawson commented on May 24, 2024 4

Hey @iansinnott thanks man, yeah I dug a bit further and saw that the flags were only set on !isRegExp(match), I've adapted the function in my project as I'm on a deadline but if I have some spare time I'll make a pull request - after a lot of searching your package finally put me on the right track!

Thanks for making FOSS :)

from react-string-replace.

iansinnott avatar iansinnott commented on May 24, 2024

Hey @jacobedawson, those flags should only be set if you don't supply your own regex, so I don't think that's the issue.

I'd guess you're running into the behavior of str.split. It will split on every match with or without regex flags. Run this in the console to see what I mean:

'hey there\nthis is a new line'.split(/( )/)

split does support a second limit argument which you might be able to use to your advantage here. I'd recommend trying that approach (either without this lib or with a fork) and seeing where you end up.

If you have a way to incorporate this into the lib that would be great too!

from react-string-replace.

kieransimkin avatar kieransimkin commented on May 24, 2024

I have now created a PR for this change: #91

from react-string-replace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.