Comments (6)
Hello. It's a common practice to place test in the same directory as core code package, i.e. in the root repo. So test is not a part of main package. When writing tests one needs to import functionality from the main package. The problem that your main package open-mcr/code
conflicts with this python module when imported as import code
. It would be very helpful for this issue, and probably for some future ones, to refactor open-mcr/code
to valid python identifier like open-mcr/open_mcr
, so core package may be safely imported as import open_mcr
.
from open-mcr.
That's a great point. Another option could be to rename code
to src
- I've seen that pattern in a couple of projects as well.
from open-mcr.
I'm ready to begin writing test with pytest module, but renaming source package name came out to be vital for running pytest. Neither with tests placed in a sibling package nor with test placed in a child package like open-mcr/code/test
it is possible to ignore conflict with python's own code
.
Do you want me to make a PR to release/1.2.0
for a change of this kind?
from open-mcr.
Hi, sorry for the delay in responding. I think we should rename the code
package to src
. I just released 1.2.0 but you can just open pull requests to master
with any changes.
from open-mcr.
Hello. There are big changes in my life recently. I may be absent for a couple of months. I will be ready to work on this when i get everything sorted out.
from open-mcr.
No worries! I may make some progress on this particular task but there will always be more to work on if you want to in the future. Thanks so much for the great work so far, and I hope everything works out well for you.
from open-mcr.
Related Issues (20)
- Add a command line interface HOT 6
- When the UI is closed without completing testing, it is never terminated and remains running in the background
- MCTA answer key files are not trimmed down to the number of actual questions used
- Add automated build / type checking HOT 1
- List of images that are bad answer sheets. HOT 1
- Convert examples to end-to-end snapshot-style tests
- Command line arguments don't support quoted file paths
- add 100 and 200 question sets also.. HOT 2
- "Failed to execute script main" error when starting OpenMCR HOT 2
- Add 200question option? HOT 4
- Buttons that open files do not work on MacOS
- Define this as a standard Python package
- Create a MacOS application version
- Build a PDF or HTML helpfile at startup from the Markdown source HOT 1
- PDF file for 150-question variant is corrupted on MacOS HOT 1
- I could not get the windows build command to work.... HOT 3
- Don't quit entire scan when a bad form image is encountered HOT 1
- Batch run with .bat HOT 1
- "Error: min() arg is an empty sequence" HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from open-mcr.