Add unit tests about open-mcr HOT 6 OPEN

Hello. It's a common practice to place test in the same directory as core code package, i.e. in the root repo. So test is not a part of main package. When writing tests one needs to import functionality from the main package. The problem that your main package open-mcr/code conflicts with this python module when imported as import code. It would be very helpful for this issue, and probably for some future ones, to refactor open-mcr/code to valid python identifier like open-mcr/open_mcr, so core package may be safely imported as import open_mcr.

from open-mcr.

That's a great point. Another option could be to rename code to src - I've seen that pattern in a couple of projects as well.

from open-mcr.

I'm ready to begin writing test with pytest module, but renaming source package name came out to be vital for running pytest. Neither with tests placed in a sibling package nor with test placed in a child package like open-mcr/code/test it is possible to ignore conflict with python's own code.
Do you want me to make a PR to release/1.2.0 for a change of this kind?

from open-mcr.

Hi, sorry for the delay in responding. I think we should rename the code package to src. I just released 1.2.0 but you can just open pull requests to master with any changes.

from open-mcr.

Hello. There are big changes in my life recently. I may be absent for a couple of months. I will be ready to work on this when i get everything sorted out.

from open-mcr.

No worries! I may make some progress on this particular task but there will always be more to work on if you want to in the future. Thanks so much for the great work so far, and I hope everything works out well for you.

from open-mcr.