Allow Conditional Loading of Modules per Server about aquarius HOT 11 CLOSED

Some additional notes - we'll probably need a new messaging utility. Something like

prompt('input string').then(response => ... ).catch(err => ...);

Which queries the server admin and resolves with their response. The user can respond cancel to stop the process, which throws the error that the module keys off of to clean up any activity.

We'll also want an optional setUp method per command that can prompt for keys or other such information. This can be used as an temporary whitelist/blacklist system as well, until a better one can be devised (just exporting an array of IDs?)

from aquarius.

The setup method should probably be a promise as well; the core bot can key off of a resolve to finish adding the module or a reject to send an error message. At this point, it might be prudent to switch the command files to a class system in a similar fashion to ARX-7

from aquarius.

Once this is done, we should bump up the version to 1.0 and release it on NPM

from aquarius.

Thinking the following format might be best - maybe rename setUp to addServer?

class Command {
  constructor() {
    this.name = 'Command';
    this.serverWhitelist = [];
    this.serverBlacklist = [];
  }

  setUp() {
    return;
  }

  message() {
    return false;
  }

  helpMessage() {
    return;
  }
}

module.exports = Command;

I made helpMessage a function because I think having the option to specialize it per server is nice; for instance, you could rename "karma" to something else per server and have it reflect in the help message.

from aquarius.

As part of this, we need a settings table - the Schema should probably look like:

from aquarius.

Actually, it might be worth combining key/value into a single config JSON field

from aquarius.

I think this might require a few extra database tables; it might be worth reorganizing what we currently have.

from aquarius.

Progress update: Settings and conditional command loading work. I've gotten an initial admin query system up that allows them to set config values, but I still need to add/remove all commands, clear up the messaging a bit, and clear set config values. The permissions system also isn't exposed to the admin yet

from aquarius.

Alright, status update - everything is done except for:

• Update Karma to read from settings
• New server created message
• Create admin command to automatically create Aquarius Roles

from aquarius.

Issues found:

• After adding all commands, a help displays an empty list of available commands
• Karma is broken (try to retrieve when none is set, the settings is broken when you try to increase)
• Help not displayed for all commands (module not found)

from aquarius.

Done and merged in 8256f76

from aquarius.