See the following PR demonstrating the issue: <a class="issue-link js-issue-link" data

Resolver still type checks even when both globalLayer and local layer are not provided about pothos-plugin-effect HOT 2 CLOSED

vecerek commented on May 28, 2024

Resolver still type checks even when both globalLayer and local layer are not provided

from pothos-plugin-effect.

Comments (2)

iamchanii commented on May 28, 2024

I just checked out your demo lightly. it is not a bug and it just a part of not implemented of this library. IMO.

pothos-plugin-effect/src/types.ts

Lines 140 to 144 in 6057f97

    
           export type PluginOptions<Types extends SchemaTypes> = EmptyToOptional<{ 
        
             defaultFailErrorConstructor?: { new(message: string): unknown }; 
        
             globalContext?: ((conext: Types['Context']) => Types['EffectGlobalContext']) | Types['EffectGlobalContext']; 
        
             globalLayer?: ((conext: Types['Context']) => Types['EffectGlobalLayer']) | Types['EffectGlobalLayer']; 
        
           }>;

I think it is caused by above types. is globalLayer able to require type based on Types['EffectGlobalContext']?

from pothos-plugin-effect.

vecerek commented on May 28, 2024

it is not a bug and it just a part of not implemented of this library

@iamchanii bug or not, I wish it didn't type check.

from pothos-plugin-effect.

Resolver still type checks even when both globalLayer and local layer are not provided about pothos-plugin-effect HOT 2 CLOSED

Comments (2)

Related Issues (17)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	export type PluginOptions<Types extends SchemaTypes> = EmptyToOptional<{
	defaultFailErrorConstructor?: { new(message: string): unknown };
	globalContext?: ((conext: Types['Context']) => Types['EffectGlobalContext']) \| Types['EffectGlobalContext'];
	globalLayer?: ((conext: Types['Context']) => Types['EffectGlobalLayer']) \| Types['EffectGlobalLayer'];
	}>;