Comments (6)
Thanks for bringing this issue to my attention! I wasn't aware that it would break the build for old compilers. I'll take a look at it this weekend to see how to address the issue (revert, document, or something else).
from data-encoding.
I would prefer revert, because https://github.com/deltachat/deltachat-core-rust tries to support Rust >=1.51 (this version introduced const generics which are required by rustcrypto crates) and depends on data-encoding via some crates, including mailparse
soon.
Also since you have a CI setup, it makes sense to fix some MSRV and automatically test that the crate can still be built with it. If some change breaks compatibility you will notice it and can decide whether it's worth rising the minimum version.
from data-encoding.
Indeed, reverting sounds like the best approach for now, but I'd like to check if there are alternatives before committing. For sure, the priority is to not break users.
Thanks for the CI idea, I'll definitely do that.
from data-encoding.
It looks like there are no clear guidelines on how an MSRV bump should impact the crate version. The Rust Embedded WG only restricts to the latest stable.
Given that the data-encoding
library is stable, I'll take the most conservative approach and only bump the MSRV when needed. I'll also do the same for the unstable macro libraries for now, but might revisit this in the future. The binary is out of scope since it cannot break a user build. Similarly, non-exported crates are out of scope.
The smallest MSRV is currently 1.46.0 according to cargo-msrv
. The MSRV is documented in the package.rust-version
field of each library and is checked in continuous integration.
If this sounds good to you, I'll submit #54.
Thanks again for bringing this issue to my attention before it was too late!
from data-encoding.
Checked #54, looks good.
from data-encoding.
Thanks! Merging.
from data-encoding.
Related Issues (20)
- Consider `check_trailing_bits=false` for BASE64_MIME decoder HOT 1
- Release 3.0.0
- Support Nix base32 HOT 1
- decode_len return a wrong result HOT 2
- Missing a new line and decode error HOT 2
- Removing dependency on syn HOT 7
- Make `{encode,decode}_len` const fns? HOT 4
- Encode into an "impl std::fmt::Write" and/or "impl std::io::Write" HOT 5
- Breaking change wish list
- Use doc_auto_cfg once stable HOT 2
- Use as_chunks family of functions once stable
- Internal symbols array is publicly exposed and unsound HOT 4
- Deny warnings in rustdoc
- Partial encoding with padding HOT 3
- Question about Specification HOT 6
- Release 2.5.0
- SIMD optimization HOT 4
- `Encoding::encode_mut` is very code-size heavy HOT 15
- feature request - base58 d/encoding HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from data-encoding.