Comments (4)
Hi Stephen
Thanks for your interest in helping out. Yes, there are number of things that could be improved
The first two things might be interesting starter-projects, the testing thing might be a bit more involved (but is sufficiently stand-alone, that it is easy to not run into merge conflicts)
-
Show current status: The renderer has a way to expose some internal state via some 'presentation_url' (grep for that in the source). This should at least display the name/version etc. of the renderer at first, but later on some (read-only) view of recently played pieces.
-
There are some feature requests that might be useful for some people (e.g. issue #5 , scrobbling to LastFM), that I haven't gotten around implementing yet.
-
Testing: right now, there are no tests, but there are many different UPnP controller out there, that want to communicate with the renderer. Sometimes, these are very picky regarding the protocol, sometimes they just have certain expectations. There were subtle problems in the past with incorrect set namespaces, that would prevent some clients from working.
It would be good if there was some kind of end-to-end test, in which we simulate a controller (the libupnp should be able to do that or maybe some plain socket-connection) and we compare the resulting XML with some string/file that contains how it is 'supposed' to be looking.
There are certainly other things you might come up with when reading the code. I inherited the code and already did a couple of cleanups, but there is more that probably can be simplified. But that is something when reading the code and probably discussing offline (I wish github would provide a mailing list, I should probably start one somewhere).
There is currently a pull request open by @ademenev which I am reviewing right now - it will add OpenHome functionality to gmrender-resurrect - more exciting features coming :) Andrey expressed interest in continuing to contribute as well.
from gmrender-resurrect.
Sounds good. I'll most likely look at testing to get me familiar with the code. I didn't spot any unit tests so I'll try to throw together something using GNU Autotest (I think that's best since you're already using GNU Autotools in the form of Automake/Autoconf?). Integration tests (like you described) would definitely be one for the future though.
With this in mind, any pointers on what you're using as a UPnP specification? Is it your own knowledge or could you point me to some documentation? Would be very useful to understand the standard (UPnP Renderer) well.
PS: You should probably throw your reply above up on the README under "Contributing" or what not - doubt I'm the only person with an interest in this project :)
PPS: Also you can close this now naturally
from gmrender-resurrect.
I have no experience with GNU Autotest, you need to explore that. I was using mostly googletest so far, but that is for C++ projects, less useful here.
The UPnP specification I got from the UPnP website:
http://upnp.org/resources/upnpresources.zip
These are nice PDFs that explain all parts of the protocol. Sometimes I refer to sections or pages in these PDFs in the code.
Just mail me privately for further discussion, might be easier.
from gmrender-resurrect.
Sounds good. I'll follow up by mail.
from gmrender-resurrect.
Related Issues (20)
- Systemd unit file not working on Raspberry Pi HOT 22
- ERROR:root:Playing failed from dlna.py github project from https://github.com/cherezov/dlnap/blob/master/dlnap/dlnap.py HOT 5
- Roughly usable but not visible on NetEase Music HOT 3
- gstout-buffer-duration HOT 3
- Run with Docker HOT 2
- uPnP device undefined HOT 2
- How to set pulsesink server ? HOT 2
- Slow subscribe events HOT 3
- Audio seek subscription HOT 3
- View connected users HOT 10
- gmrender-resurrect not building with pupnp 1.14.13 HOT 2
- Documentation of --gstout-audiodevice is incorrect
- Enhancement: Support external volume control
- daemon starts with Error: UPNP_E_INVALID_INTERFACE HOT 3
- Cut 0.1 release HOT 2
- DSD Native HOT 6
- disconnected client but device audio is still not relased HOT 6
- Compile errors with libupnp 1.14.13
- [Debian PowerPC G3] error in stdout when trying to play m3u8 stream HOT 2
- hi-fi cast on android shows only one of multiple gmediarender on intranet [v0.1] HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gmrender-resurrect.