Code Monkey home page Code Monkey logo

Comments (5)

bearded-avenger avatar bearded-avenger commented on August 16, 2024

That's exactly how it was designed.

Think if you were reading a story that has 20k words, and you accidentally swiped back on a mac mouse. Aesop will remember where you left off reading.

from aesop-core.

timnicholson avatar timnicholson commented on August 16, 2024

Oh yeah, I totally get that an Aesop story page could reposition itself
upon reload. What I'm saying is that all my OTHER pages on my site are
randomly loading half way down the page or towards the bottom of the page.
I'm even talking about pages here, not stories. The JS should check to
make sure its only doing anything if the page being loaded is an actual
Aesop story page.

BTW, I'm writing a theme that is very conducive to use of this plugin. The
reason I'm developing it is because most WordPress themes are wrapped in a
container and you can't display full-width images and colored sections.
Modern web design is all about being able to do those things and the best
sites are "telling a story" visually, verbally, and with animation as you
scroll down the page.

Tim Nicholson

On Sun, Feb 16, 2014 at 1:22 PM, Nick Haskins [email protected]:

That's exactly how it was designed.

Think if you were reading a story that has 20k words, and you accidentally
swiped back on a mac mouse. Aesop will remember where you left off reading.

Reply to this email directly or view it on GitHubhttps://github.com//issues/39#issuecomment-35207635
.

from aesop-core.

bearded-avenger avatar bearded-avenger commented on August 16, 2024

I'm fully aware of what you are telling me.

The JS is bundled into one file that runs all the time. We have to account for users that want to use these components AND who are calling the various js methods across various pages.

We can surely run a has_shortcode() check to see if ANY of the components are being used, then conditionally load the one js file, but that will completely kill any methods being called to any of the bundled plugins like swipebox or fitvids.

Make sense?

Use case, on a page of my site, I want to use the lightbox feature so I add my .swipebox class and my shit opens in a lightbox without having to place any of the components on the page. If the js file was being conditionally loaded to ONLY run on the pages that have the components, you wouldn't be able to utilize that at all.

from aesop-core.

bearded-avenger avatar bearded-avenger commented on August 16, 2024

After some thought, I've removed this from core and will be placed into an upcoming "essentials" add-on plugin.

from aesop-core.

timnicholson avatar timnicholson commented on August 16, 2024

Excellent, thanks!

I understand wanting to have access to the various javascript functions on any page or post, but its really disorienting to be moved to the bottom or middle of a page that's not using those functions at all. I'd probably recommend only repositioning the user when they hit the "back" button, not when they come back to the site and load the page fresh.

For example, I go to a website with the plugin installed and read some articles and check out their About page. I come back a month later and click to to to their About page and I'm sitting in the footer of the website. Very disconcerting to the user.

Thanks again for writing such a great plugin! I'm going to be submitting my new theme to the WordPress.org directory literally within a day or two. I'm going to add the code to contain the

tags on the Aesop pages so it will support it.

from aesop-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.