Incorrect code generation for systemd StartTransientUnit about dbus-java HOT 3 CLOSED

Thanks for the report.
The generated classes are all fine. The problem is that the generator did not remember the struct class names it already created.
This will then create the same struct class name multiple times when determining the class to use for method signature.

I fixed this in my latest commit.

I also improved the naming for the created struct classes to include the name of the argument/parameter it belongs to. This means you will get a StartTransientUnitAuxStruct and a StartTransientUnitPropertiesStruct class. I think this would improve the understanding on where the struct classes are used instead of naming them StartTransientUnitStruct and StartTransientUnitStructStruct etc.

from dbus-java.

Fantastic. I've updated my code to use your latest code and it works perfectly. Thank you!

It isn't a concern for me, but wouldn't the new naming scheme for structs be a backwards-incompatible change? It seems like that could be a suprising change in a minor release. I don't know what your compatibility model for the library is, or if this change only affects the broken codegen anyways.

from dbus-java.

Yes this is indeed a breaking change, but it only affects the code generator - therefore I'm fine that.
Also the breaking change will result in compile errors which are easily to spot and fix (other than various runtime issues you never see in advance).

The InterfaceCodeGenerator is usually used once by a developer to create the required classes/interfaces. After that there is no need to re-run it. The only reason to re-run would be updating the interfaces due to changes on the program exposing those interfaces on DBus. In this case it would be necessary to review and test your own code anyway.

The compatibility model is usually "no breaking changes in same major". But this is only true for the library (core) and the required transports - not for the utils or examples.

from dbus-java.