Comments (3)
If I understand you correctly, the problem is that a transaction may has been committed even if sendTransaction returns a rejected promise.
A easy way to correct it is ignoring the REQUEST_TIMEOUT error and continuing waiting for all event promises. For other known errors such as SERVICE_UNAVAILABLE, there is no reason to continue, right?
What's your opinion?
BTW: since step 6 is optional, when would it be applied?
from caliper.
Exactly. In my fork, I essentially ignore the orderer response (only log the error). The event results will determine the final status of the transaction.
Another thought: I use Promise.All
on the event promises, but Promise.Any
would be enough I think. If one peer successfully commits the transaction, then every other peer will commit it eventually, so the occasional event hub error of one/some peers should not deem the transaction failed. However, if I want to calculate percentile-based commit times (as discussed by the PSWG), then I need every event notification.
About step 6: it is a little fuzzy whether this should be performed in the invokebycontext
function, or as a post-processing step after the round that queries every failed, but not verified transaction. And whether to incorporate that query time somewhere or not. As a first step, I think Caliper should be able to mark such transactions as "verified after the life-cycle" to avoid false negative results and give the option for data analysts to ignore such transaction times during the analysis.
from caliper.
It sounds good. Would you please submit the PR? I'll be very happy to review it, thanks.
from caliper.
Related Issues (20)
- Caliper 0.5.0 docker image bind fails HOT 8
- Caliper Fabric support AND/OR endorsement policy? HOT 2
- Error while performing "test" step: Error HOT 3
- Benchmarking Ethereum Network (Error: Nonce undefined)
- Readme: PSWG whitepaper link is broken HOT 1
- Bug: Error Occurs When Running Documentation Locally HOT 1
- Remove references to Fisco-bcos from the vNext documentation HOT 1
- Caliper developer docs refer to a caliper-besu adapter but this doesn't exist HOT 1
- Missing Logo Image for Hyperledger Fabric on Landing Page HOT 3
- Inconsistent URL Slash Display on Documentation Link HOT 3
- On the next release of caliper after 0.5.0 we should remove the fisco-bcos logo from the main page HOT 3
- Remove the Caliper GUI Server and Caliper GUI Dashboard Packages HOT 1
- Investigate the security requirements of using caliper HOT 1
- Add Hyperlink for Caliper in README HOT 6
- Separate linting from testing in npm scripts HOT 5
- A Tutorial for using Ethereum similiar to the Fabric Tutorial HOT 1
- A Tutorial for using Besu similar to the Fabric tutorial HOT 2
- A Detailed Description about the use of the various Monitors, especially Prometheus HOT 1
- A Tutorial demonstrating using Prometheus and Grafana with Caliper HOT 1
- Missing Link: Deploy Hyperledger Caliper HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from caliper.