Comments (9)
As the docs for variants point out, a target server should only need the
AbsolutePath. The others are used mostly by proxies.
http://seanmonstar.github.io/hyper/hyper/uri/type.RequestUri.html
On Sep 17, 2014 12:19 AM, "Jonathan Reem" [email protected] wrote:
I've found the current version unergonomic to work with in downstream
libraries without just ignoring certain variants. Not sure right now what's
better, but I'll think about it.—
Reply to this email directly or view it on GitHub
#39.
from hyper.
That's what we do in Iron. I guess that's really the best we can do.
from hyper.
Though, we could add some convenience methods to get to the path.
Also, I've been thing that it might be cool to have a stronger typed value
than just a String in there...
On Sep 17, 2014 2:53 PM, "Jonathan Reem" [email protected] wrote:
That's what we do in Iron. I guess that's really the best we can do.
—
Reply to this email directly or view it on GitHub
#39 (comment).
from hyper.
We should probably use rust-url and hold a Url
value instead of a String
.
from hyper.
The tricky thing is that rust-url does not support parsing from only a relative url - you have to give it a full absolute path.
We have a huge hack in Iron where we construct a url for rust-url to parse, but I think that won't be necessary if we have all the info inside hyper.
from hyper.
Yea I wanted to use a Path from rust-url, but there isn't one yet. I tried
asking for one in servo/rust-url#14, but since I
could only offer hypotheticals, it was closed. Maybe you could give
concrete needs for Iron.
from hyper.
It looks like it was closed with a fix, does the method he added not do what we want?
from hyper.
I guess I missed that. I'd need to look into it. It looks like it validates that the value is a proper path, but otherwise returns a String.
Would it be doing too much if hyper transformed a Path + Query into something, or perhaps having a Decodable fn for getting a query? Perhaps that's better left to library land.
from hyper.
I think it's fair if Hyper provides a typed representation for request-line, with precedent being typed headers and other such things. We should just make sure to not lose any information.
from hyper.
Related Issues (20)
- Support HTTP2 upgrades with !Send executors HOT 2
- Panic in `UpgradeableConnection` due to `unwrap`
- hyper-util: client connection pool idle timeout does not work as expected HOT 4
- How does hyper serialize a Request into bytes and then send it to the server over a TCP connection?
- Lack of documentation on Read trait HOT 2
- Bug with response using struct implementing bytes::Buf HOT 4
- Hyper-util doesn't build for the web
- Issues with client termination of H2 CONNECT streams HOT 3
- `hyper` v0.14.28 fails to build w/ tokio < v1.27
- Requests with empty bodies don't set a content-length header HOT 2
- Documentation for Service::Error behavior should say it is protocol dependent HOT 1
- Current master brunch of `hyper-util` failed to compile with `client` feature enabled.
- hyper_client set client_builder.http2_keep_alive_interval(Duration::from_millis(H2_KEEP_ALIVE_INTERVAL)); got mistake HOT 1
- how hyper server set idle time out for h1 and h2 server? HOT 1
- Got error "Transport endpoint is not connected" when benchmarking the hello example with wrk HOT 2
- hyper why not support get request when send request failed becase of connection error?
- Link-local ipv6 addresses are unusable on non-Linux-like platforms HOT 2
- hyper client happens cacel error which should retry HOT 4
- It cause error when I use http client to do the http2 request HOT 1
- You should provide a command-line downloader HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hyper.