Comments (2)
There is a third option.
When a decreasing angle is provided, we should flip the basis circle (e.g. -Z normal) and make the angle increasing (but preserve the user's thought about "start" "end" in the parameterization — IOW, second parameter angle corresponds to "end", always.)
So:
in Arc constructors, if the user supplies a decreasing angle range, flip the order to be increasing and flip the basis curve direction to preserve the user's intended direction
Resulting behavior should follow this diagram.
@andrewheumann is the real expert though, and should review the solution. :)
from elements.
After some tries, it's not possible to implement what is shown because Arc parameter space is not 0 => Length but tied to the circle: first one is 0 to pi/2, second is 0 to -pi/2 or indeed 0 to pi/2 if normal is reversed. But third one is pi/2 to 0 in original direction or 3pi/2 to 2pi in reverse. Flipping Z or Transform is also have side effect of flipping X or Y axis as well to preserve correct hand rule I think this is too confusing.
It's either consistent domain and simple maintenance or more flexibility but some risks.
I did a PR with support of negative domain and fixes for Arc functions that were not consistent: #998
from elements.
Related Issues (20)
- Curve intersections.
- Unification of graphing algorithms.
- Better meshing.
- Unexpected behavior PointAtNormalized for polylines
- Regression Elements.Geometry.Solids.Sweep HOT 3
- Elliptic arc is not shown in Hypar 3D scene after importing json.
- Polygon.TransformAtNormalized returns nonsense result HOT 3
- `Bbox3(Element element)` doesn't work if the element has `RepresentationInstances` instead of `Representation`
- Lost GeometricElements during json roundtrip. HOT 2
- Incompatible library versions when write to IFC
- Inconsistencies between Contains/Covers functions
- `Transform.ToModelCurves` ignores scale
- CellComplex seems to ignore tolerance?
- Bug found while reviewing code
- Elements.Serialization.IFC HOT 6
- Got a IFC.STEPParameterMismatchException while deserializing a IFC2x3 file HOT 2
- Strange behaviour with rendering Model (in dotnet.interactive) HOT 4
- ModelText() returns System.IO.DirectoryNotFoundException when run in Notebook
- Elements.Playground doesn't run
- Error Material HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elements.