Comments (3)
I have added a FAQ entry in c79d63f to explain the reasoning.
I’m sorry you find it inconvenient, but I can’t change the API anymore (imagine all the people who rely on verify raising an exception!) and I find in security context that safety goes over typing convenience.
If you really can’t stand it, nobody's stopping you from wrapping PasswordHasher or subclassing it and adding a more pleasing façade to it.
from argon2-cffi.
This still contradicts literally every single password check function in other libraries. Why not provide another method or just a helper function that properly returns a boolean? Also, why return True
at all if the return value of the function is meaningless?
from argon2-cffi.
I agree with @ThiefMaster here. I was evaluating this library, and the raising of exceptions seems very odd, and a cumbersome api to use. The bcrypt api, for example, is much nicer to use. The seeming use of classes for classes sake, also is unfortunate.
If you really can’t stand it, nobody's stopping you from wrapping PasswordHasher or subclassing it and adding a more pleasing façade to it.
Sure. It is just busy work and hassle.
Anyway, bummer. As you consider this a misfeature, I will look around for other libraries.
from argon2-cffi.
Related Issues (20)
- RFC is no longer a draft (RFC9106); default parameter choice out of date HOT 4
- 21.2.0: pep517 does not build cython modules HOT 6
- 21.1.0: `notebook` test suite is crashing with SIGILL in _cffi_backend.cpython.*so DSO HOT 11
- Inconsistent advice for key derivation HOT 5
- How to avoid timing attacks? HOT 1
- hash function return + / verify issue with sqlite HOT 3
- Question: Can output from argon2.low_level.hash_secret_raw() → bytes directly used to derive aes key? HOT 3
- Associated data cannot be specified in the low_level functions HOT 10
- Support password verification without sending the password from client to server HOT 5
- Make hash verification return True or False HOT 4
- Second salt HOT 1
- hash() got an unexpected keyword argument 'salt' HOT 1
- ImportError: cannot import name 'PasswordHasher' from partially initialized module 'argon2' HOT 1
- Install with poetry on python 3.11.7 --obsolete
- Strange error, can't figure out what is causing it HOT 2
- Make PasswordHasher.check_needs_rehash() accept bytes hash
- Allow use of argon2 "secret" parameter for keyed hashing HOT 1
- Fail to install by pip on macOS 11.0.1 Big Sur HOT 11
- 20.1.0: sphinx warnings HOT 4
- 20.1.0: pytest warnings HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from argon2-cffi.