Code Monkey home page Code Monkey logo

Comments (3)

hynek avatar hynek commented on July 1, 2024

I have added a FAQ entry in c79d63f to explain the reasoning.

I’m sorry you find it inconvenient, but I can’t change the API anymore (imagine all the people who rely on verify raising an exception!) and I find in security context that safety goes over typing convenience.

If you really can’t stand it, nobody's stopping you from wrapping PasswordHasher or subclassing it and adding a more pleasing façade to it.

from argon2-cffi.

ThiefMaster avatar ThiefMaster commented on July 1, 2024

This still contradicts literally every single password check function in other libraries. Why not provide another method or just a helper function that properly returns a boolean? Also, why return True at all if the return value of the function is meaningless?

from argon2-cffi.

dropwhile avatar dropwhile commented on July 1, 2024

I agree with @ThiefMaster here. I was evaluating this library, and the raising of exceptions seems very odd, and a cumbersome api to use. The bcrypt api, for example, is much nicer to use. The seeming use of classes for classes sake, also is unfortunate.

If you really can’t stand it, nobody's stopping you from wrapping PasswordHasher or subclassing it and adding a more pleasing façade to it.

Sure. It is just busy work and hassle.

Anyway, bummer. As you consider this a misfeature, I will look around for other libraries.

from argon2-cffi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.