Allow to configure location of argon2 shared library and headers in setup.py about argon2-cffi HOT 7 CLOSED

That’s currently not possible and I’m not sure how to make it possible because argon2 tended to break API quite often in the past. Until very recently, nobody packaged argon2 either, so it wasn’t a legitimate problem at all.

from argon2-cffi.

I understand your point. Also most people probably just want to pip install argon2_cffi and have everything work, instead of having to install a library first.

However, I looked a bit further into the issue: In my fork of the project, there is a branch "system-argon2-poc" which contains two commits. One commit simply disables building libargon2 from the submodule. The second commit changes the include and library paths to /usr/include and /usr/lib in _ffi_build.py. I have argon2-20161029 installed on my system.

When I build and install this to a virtualenv, I can import and use the argon2 module:

$ python
Python 3.4.6 (default, Sep 10 2017, 15:00:18) 
[GCC 5.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import argon2
>>> argon2.hash_password_raw(b'1234')
b"\xb5\xe5'\x0b!r\xae\xe5t\x1a\x82\xf6\xb2\x1f\xa9z"

Do you see a way to make these changes configurable in setup.py?

from argon2-cffi.

There turns out to be a setup.py config step, which I didn't know of. I allows specifying things such as include-dirs and library-dirs:
python setup.py config --help

from argon2-cffi.

The same options are also available for the build_ext command, which seems to be more recent than config and is already executed when calling the install command. See python setup.py build_ext --help.

from argon2-cffi.

closed by #29

from argon2-cffi.

Thank you for making this happen!
And for pushing out a new release. I will try to make v18.1.0 land as a Gentoo Linux package.

from argon2-cffi.

You’re welcome and sorry it took so long. It was a delight working with you; I just wasn’t in a good place FOSS-time wise and changes to this lib are quite scary due to the impact if I screw up.

from argon2-cffi.