dispatch: modify dispatch to accept Event object instead of eventType and options about hybrids HOT 4 CLOSED

That's a great idea, also! Thank you.

from hybrids.

The main reason why I've added dispatch helper function into the library was to simplify the process of dispatching events. Because of that, I wanted this function to be as simple as possible - just passing name of event and possible options.

I am not sure what your actionCreator(/* possible data here */) returns to actionEvent, but the latter returns CustomEvent instance, right?

You can achieve a similar effect without modifying or extending dispatch function. If your actionEvent would return ['eventType', options = {}], you could use it like this:

const dispatchArgs = actionEvent(actionCreator(/* possible data here */));
dispatch(host, ...dispatchArgs);

In this way, your actionEvent does not have to create the custom event directly anymore and you still using dispatch from hybrids.

What do you think?

from hybrids.

Unfortunately, I can't rely on developers of all skill levels understanding dispatch(host, ...args) syntax. But I could provide a method that creates the init options object, and rely on all developers providing the event name manually:

dispatch(host, 'action-event', actionCreator(/* data here */))

This has the benefit of matching the existing dispatch arguments in Hyrbids. The downside is there's a bit more boilerplate for developers to write.

from hybrids.

After all you can also hide implementation details into the actionCreator, which could take host as an argument and dispatch event for that host:

dispatchAction(host, /* data here */); 

// and inside of the dispatchAction
function dispatchAction(host, /* data here */) {
  ...
  dispatch(host, 'action-event', { ..., detail: action });
}

from hybrids.