Code Monkey home page Code Monkey logo

Comments (2)

smalluban avatar smalluban commented on May 31, 2024

The model id field is always a string. You cannot change that, but you can have a storage, which requires a number - this is not a problem. Just transpose it in get and set store model methods.

However, on the "hybrids" side - in the component, store model etc.. you should use string. For example, your model type is incorrect, as the id won't be a number. You should have this:

interface IModel {
    id: string // <--- it is always a string
    content: string
}

Still, I made a fix to protect from passing numbers (it only applies to this edge case when id is 0 - as this is falsy value in JavaScript).

faec4c6

from hybrids.

Qsppl avatar Qsppl commented on May 31, 2024

Thanks for the answer.

This is not very convenient when the models are used not only by Hybrids. You have to write code like this:

interface IBaseUser { id: string | number }

interface IHybridsUser { id: string }

interface IUser { id: number }

function normalizeHybridsModel(model: IHybridsUser): IUser {
    return { ...model, id: Number(model.id) }
}

function convertToHybridsModel(model: IUser): IHybridsUser {
    return { ...model, id: String(model.id) }
}

If such a restriction on the "id" property is really necessary, then it is worth adding it to the generic of type Model:

image

export type Model<M extends { id?: string } & object> = {
    [property in keyof Omit<M, "id">]: Required<M>[property] extends Array<
        infer T
    >
    ? NestedArrayModel<T> | ((model: M) => NestedArrayModel<T>)
    : Required<M>[property] extends object
    ? Model<Required<M>[property]> | ((model: M) => M[property])
    : Required<M>[property] | ((model: M) => M[property])
} & {
    id?: true
    __store__connect__?: Storage<M> | Storage<M>["get"]
}

Then the following error will pop up:
image

from hybrids.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.