Describe the bug Dot-notated paths passed to the <code class="notr

Dot-notated paths passed to the `useProperty` become invalid when reaching for a key past a nullable key about hybridly HOT 1 CLOSED

hybridly commented on May 22, 2024 2

Dot-notated paths passed to the `useProperty` become invalid when reaching for a key past a nullable key

from hybridly.

Comments (1)

nhedger commented on May 22, 2024

I believe that the following two problems need to be solved:

The type of the path should be fixed in a way that it traverses the whole target type, regardless of nullable keys.
The return type of useProperty should be either the type of the final fragment (e.g. SecurityData when using useProperty('security')) or a union of undefined and the type of the last fragment if there were any nullable keys in the chain (e.g. undefined|string) when using useProperty('security.user.name').

For the first problem, I've come with the following solution:

--- a/packages/vue/src/composables/property.ts	(revision 62d1293548e994cd2e997c6aa64e178526f54b9b)
+++ b/packages/vue/src/composables/property.ts	(revision e5df3f34973aff49e94ca5dd521b565782abc98e)
@@ -41,10 +41,10 @@
 
 type PathImpl<T, K extends keyof T> =
 	K extends string
-		? T[K] extends Record<string, any>
-			? T[K] extends ArrayLike<any>
-				? K | `${K}.${PathImpl<T[K], Exclude<keyof T[K], keyof any[]>>}`
-				: K | `${K}.${PathImpl<T[K], keyof T[K]>}`
+		? NonNullable<T[K]> extends Record<string, any>
+			? NonNullable<T[K]> extends ArrayLike<any>
+				? K | `${K}.${PathImpl<NonNullable<T[K]>, Exclude<keyof NonNullable<T[K]>, keyof any[]>>}`
+				: K | `${K}.${PathImpl<NonNullable<T[K]>, keyof NonNullable<T[K]>>}`
 			: K
 		: never