WebSocketV1ClientBase.lastReceivedTime field data race about huobi_golang HOT 6 CLOSED

Just:

p.timeMutex.Lock()
p.lastReceivedTime = time.Now()
p.timeMutex.Unlock()

from huobi_golang.

Same for WebSocketV2ClientBase

from huobi_golang.

@filinvadim thanks for the feedback, usually this won’t happen, however it has possibility in theory as lastReceivedTime is written in two routines. I don’t want to introduce mutex, so just move the lastReceivedTime initialization to earlier places. You can check the latest master branch.

from huobi_golang.

@eynzhang so data race is still in place. You need a mutex, sorry.

from huobi_golang.

@filinvadim could you share how you reproduce this issue?

from huobi_golang.

Sorry no, @eynzhang . It's in your code. Just go run --race ...
You have access to the variable lastReceivedTime from 2 threads - tickerLoop and readLoop. That's data race. Reopen please to warn other developers.

from huobi_golang.