Exclude page template names from dash naming rules about coding-standards HOT 7 CLOSED

Looks like these should actually already be excluded: WordPress/WordPress-Coding-Standards#960 🤔

from coding-standards.

You may want to add the following for themes.

<rule ref="WordPress.Files.FileName">
	<properties>
		<property name="is_theme" value="true" />
	</properties>
</rule>

https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/wiki/Customizable-sniff-properties#themes-allow-filename-exceptions

from coding-standards.

Ah, I see. I guess there's no way for us to set that dynamically.

from coding-standards.

Needs more investigation and a refresh, PHPCS behavior here may have changed, we haven't seen this issue recently.

from coding-standards.

This is still an issue, but only for names with underscores in them. For example, single-example.php will pass, but single-example_example.php will not.

It looks like is_theme has no other side effects so there's a rather simple solution.

from coding-standards.

Ah, right. What a weird setting.

from coding-standards.

Indeed; I would have assumed that this would always be set but 🤷

from coding-standards.