group.forEach is not a function about postcss-sorting HOT 8 CLOSED

Stylelint config is not fully compatible with this plugin yet. gajus/stylelint-config-canonical@2c58f19#diff-33d8a40ae0050661239a87463149dcafR4 array of arrays will be a correct config for PostCSS Sorting.

from postcss-sorting.

@hudochenkov Would you accept a PR that makes this change? or is there a reason this is on hold (since it does not look like a big change)

from postcss-sorting.

It's a big change because it would broke plugin backwards compatibility. Grouping in this plugin allows to group declarations, nested rules, at-rules. See default config. Stylelint only support grouping for declarations only.

We are working now on a plugin for stylelint which will check sort order for non declarations (nested rules, at-rules). After this plugin will be ready I will think about how to integrate postcss-sorting in stylefmt, tool which format style sheets based on stylelint config. Now stylefmt support stylelint's declaration-block-properties-order, but only with config like this: ["array", "of", "unprefixed", "property", "names"].

from postcss-sorting.

It's a big change because it would broke plugin backwards compatibility.

I disagree. This plugin could support both syntaxes without introducing backwards breaking changes.

from postcss-sorting.

I'll be glad if you right because it would be a great feature. Feel free to make a PR if it only adds new syntax and won't break anything.

from postcss-sorting.

After this plugin will be ready I will think about how to integrate postcss-sorting in stylefmt, tool which format style sheets based on stylelint config.

This is an excellent idea! It looks like stylefmt added support for declaration-block-properties-order yesterday using postcss-sorting. Is there a chicken and egg thing going on here? Either way, it's feels like things are coming together nicely and that your stylelint plugin will be the missing piece of the puzzle :)

from postcss-sorting.

@jeddy3 Yeah, I found out about this support from PostCSS twitter :) And as I can see, it's very limited support. I'm going to fix that too :) It's won't be a full support, because stylelint have “flexible” order option, and postcss-sorting do strict order only. But I will change stylefmt's part of declaration-block-properties-order to support stylelint's rule as close as possible.

from postcss-sorting.

It's won't be a full support, because stylelint have “flexible” order option, and postcss-sorting do strict order only.

That makes sense to me. I'm not sure how many people use the "flexible" order option, but I suspect it's a much smaller number than the combined total of people who use alphabetical or define a strict custom order. If someone does use the "flexible" order option, then they can always PR the support themselves if they want it :)

from postcss-sorting.