Code Monkey home page Code Monkey logo

Comments (7)

zackbloom avatar zackbloom commented on July 28, 2024

Are you testing against a locally hosted page (hosted on your machine)?

from offline.

zackbloom avatar zackbloom commented on July 28, 2024

Do you see it if you disconnect your internet on the demo page: http://github.hubspot.com/offline/docs/welcome/

That page uses the offline.min.js file in master.

from offline.

andygup avatar andygup commented on July 28, 2024

@zackbloom Can you consider reopening this issue? Offline detection is definitely not working for me on the following using my own app as well as the demo page you mention above:

Windows 7 with Chrome 35 and Safari 5.1.7. (also doesn't work after reloading via application cache while offline)
Genymotion Android emulator running 4.4.2 on Mac specifically when app is reloaded using an application cache while offline

Note, on my Mac running OSX 10.9.2, Chrome Canary and Safari 7.0.3 seem to work okay.

This is potentially a showstopper bug for using this library.

from offline.

zackbloom avatar zackbloom commented on July 28, 2024

Just to confirm @andygup, even when you make an XHR request and that request fails (while you're offline), you still don't see it?

from offline.

andygup avatar andygup commented on July 28, 2024

Yes on Windows.

I'm still digging into what's going on with the Genymotion Android emulator. It appears that running the offline library from the application cache is affecting it somehow. Interestingly, the library's does seem to internally detect an offline condition and it starts trying to make HTTP requests (and they fail) however it doesn't seem to be passed on as an "up" or "down" event...

from offline.

andygup avatar andygup commented on July 28, 2024

Quick update. The Windows issue still stands.

I've fixed the Genymotion issue. That was a coding error on my end. The offline detection is working correctly on Android 4.4.2.

from offline.

andygup avatar andygup commented on July 28, 2024

@zackbloom any chance of reopening this just so others are aware?

from offline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.