Code Monkey home page Code Monkey logo

Comments (9)

barryvdh avatar barryvdh commented on July 28, 2024

The default check is changed to xhr, and the default image/xhr don't exist. So you have to set the options.

checks: {
    image: {
        url: 'my-tiny-image.gif'
    },
    active: 'image'
}

or

checks: {
    xhr: {
        url: 'my-xhr-request'
    },
    active: 'xhr'
}

from offline.

 avatar commented on July 28, 2024

I might be doing something wrong but I think the new version is somewhat broken. on version 0.4.7 all I needed to do is add JS and CSS from the page and it works. The only browser it didn't work was Firefox so I added this:
var run = function(){
if (Offline.state === 'up')
Offline.check();
};
setInterval(run, 3000);
and it worked fine everywhere.

On new version 0.6.0 the code is a must and only works if i use xhr with errors. Image detection does not work anymore. If I put a wrong URL in the "image: { url:" then it will display the notification even I am online but as long as I use older version CSS (new one does not even show up). The old CSS does not show the timer Reconnecting in anymore (instead shows ...). If the image is correct when it will not show any 404 errors but when I disconnect Internet nothing happens.

I'll try few more things but I am running out of ideas. It simply doesn't work anymore :/

from offline.

barryvdh avatar barryvdh commented on July 28, 2024

I added this:

Offline.options = {
    checks: {
        image: {
            url: function() {
               return 'http://my-domain/img/tiny-image.gif?_=' + (Math.floor(Math.random() * 1000000000));
            }
        },
        active: 'image'
    }
}

And placed the tiny-image.gif on my own domain. When just using a static filename, it only triggers the first check and then loads from cache (I suspect)

from offline.

 avatar commented on July 28, 2024

Well your solution does work to me. Kinda strange way to do it :) Maybe there will be a better solution in the future. You might be able to add this functionality in the offline.min.js and only set option to chose what u want xhr or image?

Thanks for your help. At least temporarily it works now

from offline.

barryvdh avatar barryvdh commented on July 28, 2024

Yeah it changed with this commit: a8b9773
But it isn't really clear from the readme that you have to set your own checks, because the default doesn't work anymore..

from offline.

kcent-hg avatar kcent-hg commented on July 28, 2024

@barryvdh your fix worked for me, thank you! It would certainly be helpful for the docs to be updated to specify the new config requirements.

Thanks all!

from offline.

gutyril avatar gutyril commented on July 28, 2024

This solution does not work for 3G connection, only with Wifi. Do you have any workaround?

from offline.

andygup avatar andygup commented on July 28, 2024

The fix mentioned by @barryvdh also worked for me. We were using the old library are starting getting a ton of 403 errors out the blue.

from offline.

zackbloom avatar zackbloom commented on July 28, 2024

v0.7.0 now uses your favicon as the test image, assuming you have a /favicon.ico, you should see no problems.

from offline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.