xhr.onprogress is "undefined" in IE + jQuery about offline HOT 5 CLOSED

I'm a little confused, the purpose of the check near line 166 is to force older browsers which don't support XMLHttpRequest2 to use onreadystatechange: https://github.com/HubSpot/offline/blob/master/js/offline.js#L171

Meaning, it was checking specifically that it was undefined on IE9, and it was correctly avoiding a code path which wouldn't work. Before making your change, what was happening in IE9. Was it just not showing up?

The readyState is correctly 1 before sending the XHR (it's set by the browser, not jQuery). It will then later be reset to 0 if there is a network issue.

from offline.

I was seeing xhr.onprogress == "undefined" (non-null), and so it was entering the onreadystatechange path in IE9.

So instead of this:

if (xhr.onprogress === null) {

I changed to this:

if (xhr.onprogress === null || xhr.onprogress === undefined) {

And (strangely?) it works. I see what you're saying though - in IE9 those events (error/timeout) shouldn't even be available. Hm...I'm definitely running IE9.

When it was in the onreadystatechange block my readyState was always "1", and even after a failure it remained "1", so the disconnected functionality was never kicking in. This might be due to how I was testing though: I was just being lazy and stopping my local server before the request (causing it to fail). I suspect if I tested properly against a remote server and broke the connection I may see a different result..?

Thanks, and apologies for the confusion. :)

from offline.

IE9 does not support XMLHttpRequest2, but I believe it does support onload and onerror events on the XDomainRequest object, which is used for cross-origin requests. In any case though, the onreadystatechange block should work. readyState of 1 generally means that open was called, but send was not on the XMLHttpRequest object.

from offline.

Right. I'm going to dig a bit deeper and see if I can nail down what's going on here. I appreciate the quick replies!

from offline.

Please reopen if you still have this issue.

from offline.