Comments (4)
dahlbyk
commented on June 26, 2024
So I got Heroku review apps set up on #201....and GitHub OAuth rejects auth because the URL doesn't match. This is...unfortunate.
from huboard-web.
dahlbyk
commented on June 26, 2024
I mentioned this challenge to @Steven-Pingel and he directed me toward http://stackoverflow.com/a/32544022/54249. We should be able to use HEROKU_APP_NAME and HEROKU_PARENT_APP_NAME to effectively direct per-PR authorizations through the parent app.
from huboard-web.
dahlbyk
commented on June 26, 2024
Looks like we're going to have to replace Warden::GitHub::Config.normalized_uri(), which is hard-coded to build redirect_uri from request.url.
from huboard-web.
dahlbyk
commented on June 26, 2024
Now that the relevant code has been shipped, review apps can be deployed from https://dashboard.heroku.com/apps/huboard-rails/deploy/github. PRs without the new app.json (and relevant Warden code) won't work, so we'll want to pull master into any open branches that we want to review.
from huboard-web.
Related Issues (20)
- Continuous Integration with Travis CI HOT 1
- Message: no implicit conversion of String into Integer HOT 1
- Label filters with the same name as a linked repo bind incorrectly
- Analytics correlation is still not working correctly HOT 2
- TODO:// hb-task-list.js possibly needs refactored
- Powerbar should look "full" when issues are closed but the state label isn't in the final column
- Flexible column widths is having issues at certain browser widths HOT 3
- Drag avatar to assign is currently broken in master HOT 1
- Card disappearing on reorder HOT 3
- TODO:// move any App.get global calls to some kind of service
- Card drag perfomance regression in Firefox
- Unable to create new board
- Disallow reopen on merged PR's
- [UX] Title should be on the top of the card
- [UX] Title font should be bigger
- [UX] Hide comments when 0 comments
- [UX] Better icon support for cards to indicate Issue vs PR & status
- Unhandled Expired CSRF Token
- "Super Squishing" Board UX quirks
- Code snippet test HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from huboard-web.