Please support events without event names about async-sse HOT 6 CLOSED

@yoshuawuyts ☝️

from async-sse.

Hmm, I didn't expect people to wanr to send messages without an event name, but I guess that's proven to be overly limiting.

I think the first option would be the most straightforward; issuing a semver major seems fine for this as well.

Though I wonder: if we make the argument impl Into<Option<&str>>, that should work with both string literals and None right? If that works I don't believe that would be a breaking change since all previous inputs are accepted, but it's possible to pass None to omit the name. (Not near a computer right now so can't confirm if this works)

from async-sse.

Hmm, I didn't expect people to wanr to send messages without an event name, but I guess that's proven to be overly limiting.

For short messages, event: xyz adds substantial overhead.

Though I wonder: if we make the argument impl Into<Option<&str>>, that should work with both string literals and None right? If that works I don't believe that would be a breaking change since all previous inputs are accepted, but it's possible to pass None to omit the name. (Not near a computer right now so can't confirm if this works)

That's a good idea, and it'd be much easier for people to use. It would not technically be a breaking change by the normal compatibility rules, but it could potentially break code that was relying on inference. I think it'd still be a good idea to do a major version bump for it, but most people should just be able to recompile their code. I'll implement that.

from async-sse.

Fixed in #15

from async-sse.

released in v5.0.0 — I think it should be possible to use a patch.crates-io to use this with tide 0.15, but I haven't confirmed that. If not, tide bump will probably wait for next tide minor

from async-sse.

ref: http-rs/tide#760

from async-sse.