Add options for encoding nested form and query params a la clj-http about http-kit HOT 7 OPEN

@ptaoussanis I went back and re-ran the rake command to see again what had happened and why I got worried it wasn't working. I admit I didn't investigate too closely because I found I was able to run lien test org.httpkit.client-test so I just focused on that. And BTW those specific tests, including the new ones I added, all passed.

This is what happened. I just wasn't patient enough. When it gets to testing org.httpkit.ws-test it starts emitting the same warning about worker threads every 10 seconds or so, and initially I thought something was stuck in a loop and I cancelled it. But this time I let it go (I came over here to write this comment) and after a dozen or so of those, it completes.

And again, the results shown above are in my fork with the new client tests.

from http-kit.

@wevre Hi Mike,

Thanks for the clear info, that's very helpful! Would be happy to take a look at a PR to add options to match clj-http! 👍 🙏

from http-kit.

Is there a recommended Java version to use when running the tests? I'm currently running with OpenJDK Temurin-21.0.1+12 but not all the tests are compiling/passing.
[Edit] Nevermind. I'm able to run lein test org.httpkit.client-test and I'll just focus on that.

from http-kit.

@wevre To clarify: the tests fail on your system even as of the current master, or only after your changes?

The tests aren't unusually sensitive to JVM version as far as I'm aware, and are passing with at least OpenJDK 21 and 17.

Could you please share the failure you're seeing?

from http-kit.

BTW I've just updated the CI tests to cover Corretto OpenJDK 17, 19, and 21 - all of which seem okay on the current master 👍

from http-kit.

Is it possible to use httpkit as a :local/root dependency? It must be, right?

I wanted to test the fork directly in my project to do some Stripe calls, but when I start up my system/server (I'm using Integrant) I get an error that:

{:type java.io.FileNotFoundException
   :message "Could not locate httpkit/with_channel__init.class, httpkit/with_channel.clj or httpkit/with_channel.cljc on classpath. Please check that namespaces with dashes use underscores in the Clojure file name."
   :at [clojure.lang.RT load "RT.java" 462]}

The more I think about this, I think it is an issue with Integrant and attempting to reload changed namespaces. But why does it think that the macro org.httpkit.server/with-channel is a namespace?

UPDATE: I found a with-channel namespace, under 'resources/clj-kondo.exports'. I'm not familiar with exactly what that is, but I nuked it and am able to now work with my fork as a :local/root deps. I tested :nested-param-style :indexed and it worked.

from http-kit.