Code Monkey home page Code Monkey logo

Comments (7)

niutech avatar niutech commented on August 26, 2024

Now it works in IE10 and IE9, but it won't work in IE8 due to incorrect execution of JavaScript. Please upgrade your browser.

from htmlpreview.github.com.

dotnetwise avatar dotnetwise commented on August 26, 2024

From developer's perspective:

Upgrade my browser? You kidding me?
I'm using htmlpreview for running tests, to show that my github library works on IE7/IE8 as well (for those who are concerned about backward compatibility.

From end user's perspective:

You can't uprade from IE8 on a XP computer. A lot of big corporates won't upgrade their XPs, sadly.

From my pserspective:

Your code is perfectible.
From minified version

a=[].slice.call(document.getElementsByTagName("iframe")).concat([].slice.call(document.getElementsByTagName("frame")));

This is wrong, because document.getElementsByTagName returns a NodeList not an Array.
Why do you need to call slice anyways?

a=Array.prototype.concat.apply(Array.prototype.concat.apply([], document.getElementsByTagName('iframe')), document.getElementsByTagName('frame'))

Would work just fine on IE7/8 as well!

from htmlpreview.github.com.

dotnetwise avatar dotnetwise commented on August 26, 2024

So what's the status?
The above looks like quick fixes to me.

from htmlpreview.github.com.

niutech avatar niutech commented on August 26, 2024

What [].slice.call(document.getElementsByTagName("iframe")) does is just converts a NodeList to Array in order to build one array of all iframes and frames in a document. I have changed that line and it seems to work OK in IE8 (checked in IE10 in IE8 compatibility mode), so it must be something else that breaks HTMLPreview in IE8.

from htmlpreview.github.com.

dotnetwise avatar dotnetwise commented on August 26, 2024

How is that? It doesn't work at all.
Look here for a fair-working answer: http://stackoverflow.com/a/13318066/219349

from htmlpreview.github.com.

niutech avatar niutech commented on August 26, 2024

I have changed the code according to your remark and it works in all modern browsers. I don't have IE8, but it worked using IE8 mode in IE10. What's the error you got?

from htmlpreview.github.com.

dotnetwise avatar dotnetwise commented on August 26, 2024

Excellent, now IE8 works just perfect.
I don't have IE8 native too, but simulating IE8 compatibility mode is always a good 100% test for javascript issues.

Now IE7 has some bigger problems :)
SEC7112: Script from https://raw.github.com/dotnetwise/Javascript-FastClass/master/src/Scripts/Tests/qunit.js was blocked due to mime type mismatch

from htmlpreview.github.com.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.