Comments (7)
Now it works in IE10 and IE9, but it won't work in IE8 due to incorrect execution of JavaScript. Please upgrade your browser.
from htmlpreview.github.com.
From developer's perspective:
Upgrade my browser? You kidding me?
I'm using htmlpreview
for running tests, to show that my github library works on IE7/IE8 as well (for those who are concerned about backward compatibility.
From end user's perspective:
You can't uprade from IE8 on a XP computer. A lot of big corporates won't upgrade their XPs, sadly.
From my pserspective:
Your code is perfectible.
From minified version
a=[].slice.call(document.getElementsByTagName("iframe")).concat([].slice.call(document.getElementsByTagName("frame")));
This is wrong, because document.getElementsByTagName
returns a NodeList
not an Array
.
Why do you need to call slice
anyways?
a=Array.prototype.concat.apply(Array.prototype.concat.apply([], document.getElementsByTagName('iframe')), document.getElementsByTagName('frame'))
Would work just fine on IE7/8 as well!
from htmlpreview.github.com.
So what's the status?
The above looks like quick fixes to me.
from htmlpreview.github.com.
What [].slice.call(document.getElementsByTagName("iframe"))
does is just converts a NodeList
to Array
in order to build one array of all iframe
s and frame
s in a document. I have changed that line and it seems to work OK in IE8 (checked in IE10 in IE8 compatibility mode), so it must be something else that breaks HTMLPreview in IE8.
from htmlpreview.github.com.
How is that? It doesn't work at all.
Look here for a fair-working answer: http://stackoverflow.com/a/13318066/219349
from htmlpreview.github.com.
I have changed the code according to your remark and it works in all modern browsers. I don't have IE8, but it worked using IE8 mode in IE10. What's the error you got?
from htmlpreview.github.com.
Excellent, now IE8 works just perfect.
I don't have IE8 native too, but simulating IE8 compatibility mode is always a good 100% test for javascript issues.
Now IE7 has some bigger problems :)
SEC7112: Script from https://raw.github.com/dotnetwise/Javascript-FastClass/master/src/Scripts/Tests/qunit.js was blocked due to mime type mismatch
from htmlpreview.github.com.
Related Issues (20)
- tabset not showing HOT 1
- 404: Not found HOT 1
- Update link in project description? HOT 1
- luajit doc not show left nav pane
- How can I use and host HTML Preview on my server or local?
- Preview a html with javascript type set on module.
- JavaScript-based swagger-ui won't be displayed
- htmlpreview could be the default link to display ipynb (notebooks)
- Root Folder Name
- er
- Also works with gists... HOT 1
- Javascript window load event fires inconsistently
- Browser Console Error Loading Favicon.ico
- Ease of Use - Copy and Pasting Link to Use
- nosniff blocking css loading? HOT 2
- Web page does not load - is htmlpreview broken ? HOT 3
- External links with # gets broken. HOT 4
- My HTML webpage is not loading and keep disappearing after it load for split second
- Repo is abandonned -> New Fork! HOT 2
- Preview
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from htmlpreview.github.com.