Code Monkey home page Code Monkey logo

Comments (4)

niutech avatar niutech commented on August 26, 2024

The last change allows pages like Impress.js to work, by forcing the right order of <script>s. Before this, all external <script src>s were executed at the end, after executing inline <script>Impress.init()</script>, which caused an error of Impress being undefined. Moving inline <script>s to the end as well restores the right order of JS.
However, I will look closer at this issue and make some fix soon.

from htmlpreview.github.com.

astangl avatar astangl commented on August 26, 2024

How about simply storing script.length into another variable before starting the loop, and then compare against that in the for loop? That way it will only iterate over the original size of the array, regardless of whether the array grows during loop iteration.

from htmlpreview.github.com.

niutech avatar niutech commented on August 26, 2024

There's much simplier solution - replacing getElementsByTagName with querySelectorAll, which returns a static NodeList.

from htmlpreview.github.com.

astangl avatar astangl commented on August 26, 2024

Looks good now in Chrome, thanks!

from htmlpreview.github.com.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.