Wrong emission of st_align(4)_u8 HSAIL insn about gccbrig HOT 4 CLOSED

This is an illegal instruction:

st_align(4)_u8 9, 0, 0, 0, [$d0+8];

st takes only two arguments, this has somehow pushed in 5. HSAILasm can disassemble the BRIG, but cannot assemble it again:

$ HSAILasm -disassemble phsa-temp/program-0.brig 
$ HSAILasm phsa-temp/program-0.hsail

>       st_align(4)_u8  9, 0, 0, 0, [$d0+8];
>                          ^
input(10,20): Invalid operand 1, expected: an address

I wonder how can it work for some other platform. Using the standard struct parsing, I cannot get access to the 9 byte in that list.

from gccbrig.

Ok, I will fix that in HSA back-end, however can you please paste here a link to an issue you did for HSAILAsm?

Thanks

from gccbrig.

I didn't because I wasn't sure if this is a HSAILasm bug after all. It should complain in case trying to disassemble an illegal BRIG such as this? It complains when it tries to assembly it.

from gccbrig.

I think so, because they do it in different situations where an assembled BRIG is invalid.
They will appreciate that, maybe it can catch more cases.

Martin

from gccbrig.