Code Monkey home page Code Monkey logo

Comments (14)

uga-rosa avatar uga-rosa commented on July 30, 2024 1

Let's make another issue.

from cmp-cmdline.

fmoda3 avatar fmoda3 commented on July 30, 2024

I have the same problem. After trying various commits, looks like this one broke it: d8738f0

image

from cmp-cmdline.

JKubovy avatar JKubovy commented on July 30, 2024

I've got same problem.

from cmp-cmdline.

fmoda3 avatar fmoda3 commented on July 30, 2024

@uga-rosa @hrsh7th Any chance we can revert d8738f0 to fix this issue?

from cmp-cmdline.

uga-rosa avatar uga-rosa commented on July 30, 2024

What makes it VARIABLE is that it is defined as such.

kind = cmp.lsp.CompletionItemKind.Variable,

What does this revert mean? The number that comes right after the : represents a range, and it would be correct to line up a command that can take a range (:h :range).

from cmp-cmdline.

fmoda3 avatar fmoda3 commented on July 30, 2024

I goto line all the time with :150 as an example, which used to work fine, but now creates a very incorrect completion list like you can see above. Perhaps reverting isnt the right solution, but that commit did break something (as seen in the images above). Note the first image too, where it happens with non-number prefixes. I've pinned my plugin to the commit prior to this, but would prefer not to do that, if there is an appropriate fix.

from cmp-cmdline.

uga-rosa avatar uga-rosa commented on July 30, 2024

It is true that there are some commands out there that do not allow range, but it is correct in itself that the command is completed with :{number}. For example, :1w is a formal command.
And isn't this issue a report that the kind is variable? I explained in my earlier reply that that is the spec.

from cmp-cmdline.

fmoda3 avatar fmoda3 commented on July 30, 2024

Perhaps there is a separate underlying issue. I don't know the codebase, and i dont know what the right fix would be. All i know is that its basically unusable in its current form, and i had only found the commit where the issue started occurring.

from cmp-cmdline.

uga-rosa avatar uga-rosa commented on July 30, 2024

I have no idea what you think the problem is, or how reverting back to before that commit will fix it. I can't reply any further if you don't explain it to me in detail from scratch. You and I do not share the same premise.

from cmp-cmdline.

fmoda3 avatar fmoda3 commented on July 30, 2024

Here's how it worked before d8738f0:

typing just :150 shows no completions yet:
image

then when you type another character, it starts to complete:
image

but now typing just :150 shows a huge list:
image

while I understand that the large list in the second technically is correct in that its showing every possible completion, I would argue that the previous behavior was more useful. Similarly, if i just type : it doesn't show me everything i can complete with yet, it waits until i have one character to start completing. The way numbers complete now, feels equivalent to just showing me every possible command right off the bat. At least I think having the option to complete using the old behavior should be made available.

from cmp-cmdline.

fmoda3 avatar fmoda3 commented on July 30, 2024

ah, i think my issue is different that the one from the original poster (when i originally thought it was the same). I can move it to its own issue, though i don't think i can move the discussion.

from cmp-cmdline.

windowsrefund avatar windowsrefund commented on July 30, 2024

I can no longer reproduce this and assume a recent update must be responsible for the fix.

from cmp-cmdline.

windowsrefund avatar windowsrefund commented on July 30, 2024

The original issue is back now that I've updated to commit 8ee981b

from cmp-cmdline.

hrsh7th avatar hrsh7th commented on July 30, 2024

Please create new issue.

The Variable type issue is not a valid issue.

from cmp-cmdline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.