Code Monkey home page Code Monkey logo

Comments (4)

paugier avatar paugier commented on August 26, 2024 2

My 2 cents: there is a discussion to depreciate distutils (https://www.python.org/dev/peps/pep-0632/). Now that we have pep517 and isolated builds with pyproject.toml, supporting builds using hpy with only distutils doesn't seem to be very useful.

from hpy.

hodgestar avatar hodgestar commented on August 26, 2024

I pushed a small fix to https://github.com/hpyproject/ultrajson-hpy/tree/antocuni/update-to-latest-hpy.

The high-level issue is that ultrajson-hpy's setup.py was passing the distutils version of build_ext rather than the setuptools one.

The question now is what to do about it on the HPy side? It's likely a common and confusing issue, so we should do something.

One option is to try detect the issue and either raise an error or warning. One way to detect the issue is to check whether the setuptools build_ext is somewhere in the inheritance hierarchy of the current build_ext. If it isn't, the build will probably fail anyway.

Another option is to somehow handle the case where only distutils is being used, but I don't really know what that should look like, other than that it would probably be even more of a mess.

from hpy.

antocuni avatar antocuni commented on August 26, 2024

One option is to try detect the issue and either raise an error or warning. One way to detect the issue is to check whether the setuptools build_ext is somewhere in the inheritance hierarchy of the current build_ext. If it isn't, the build will probably fail anyway.
Another option is to somehow handle the case where only distutils is being used, but I don't really know what that should look like, other than that it would probably be even more of a mess.

I don't know enough on the subject to make a reasonable comment. I am fine with both options if they improve the current situation.

from hpy.

hodgestar avatar hodgestar commented on August 26, 2024

Addressed by #178.

from hpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.