Comments (4)
A potential fix might be changing PExprOpt>>doEval: to
doEval: state
| originalInputState result input |
input := state inputStream.
originalInputState := input getState.
result := self term eval: state.
result
ifFalse: [ input setState: originalInputState.
state
addNodeNamed: self class terminalRuleIdentifier
startedAt: originalInputState
withChildren: ((1 to: self arity) collect: [:n | nil]). ].
^ true
from ohm-s.
Actually the issue is the following: If the parse succeeds the intermediate results remain on the stack and are not aggregated into one Optional node. If the parse fails it is aggregated into an optional node. Again we have to check Ohm/JS
from ohm-s.
Ohm/JS does yield a node for every node IN an optional node but they might only contain empty strings
from ohm-s.
Fixed in 5030837
from ohm-s.
Related Issues (20)
- Smalltalk grammar problem with message receivers
- BinarySelectorChar in OhmExplicitSendsSmalltalk HOT 1
- OhmExplicitSendsSmalltalk has only OperandCascades HOT 2
- Allow access to skipped whitespace HOT 13
- not in a sequence in a syntactic rule skips spaces
- BinaryCascade in latest fix HOT 6
- #replaceParametersWithArguments: creates unnecessarily deep copies
- The results of many pexprs produce ambiguous nodes
- FindFirst:startingAt: not understood HOT 2
- Empty OhmIntervals at 0 and self size are inconsistent HOT 1
- In terminalExpression a text instead of a string
- OhmSHRuleParser errors on incomplete Smalltalk method
- OhmCheckStructure does not check rule name
- New super-splice operator
- Grammar compilation of lexification operator produces error
- Parsing based on left-recursive rules differs from Ohm/JS
- Smalltalk grammar parsing of literal arrays differs from legacy parser
- Expression may also contain an assignment
- Grammars reference parsing state of previous parse operations HOT 3
- Make recording of OhmSyntaxTestCase results optional
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ohm-s.