Query string parsing is potentially misleading about node-mocks-http HOT 4 OPEN

Hi @alxndrsn thanks for reporting this issue.

Indeed, Express.js by default uses qs instead of querystring.
I agree that for better compatibility node-mocks-http should also use qs.

Since this project relies a lot on contributors, we'd really appreciate it if you could come up with a fix. Thanks a bunch!

from node-mocks-http.

I agree that for better compatibility node-mocks-http should also use qs.

That's not what I'm suggesting - I think doing any parsing of query strings is going to give misleading results for some users in some situations.

Here are the parsers used by the frameworks listed in https://github.com/eugef/node-mocks-http/blob/master/README.md:

Safe approaches might be to:

1. deprecate query string parsing in this library and log a warning
2. remove query string parsing from this library
3. require explicit configuration of a particular parser
4. allow some way to derive which parser to use from a user-supplied application instance

Option 2 would seem the simplest & safest, with obvious inconvenience for anyone using this feature.

from node-mocks-http.

Stale issue message

from node-mocks-http.

To keep library backwards compatible we will continue using built-in querystring but add a configuration option to allow using other parsing libs

from node-mocks-http.