Remove complete state from lazily-loaded frame about turbo HOT 5 CLOSED

Fixed in #1175

from turbo.

Hi @brunoprietog, I've just gotten round to upgrading to turbo 8.0.5 (I think this was closed as part of 8.0.4), but I'm still experiencing this issue. As soon as I removeAttribute("complete"), it just gets added in again straight away.

My use case is a dropdown menu that contains a turbo frame. Whenever the dropdown menu opens, the turbo frame should be requested. When the dropdown menu closes, the turbo frame is cleared and the complete attribute is removed, so that it is re-requested the next time the dropdown menu opens. When I upgrade to 8.0.5, the turbo frame is not requested and my dropdown stays empty.

from turbo.

Could you show some code? Anyway, the complete attribute is not intended to be used that way. Instead, you could reload the Turbo frame maybe? Delete the contents of the Turbo frame with something like frame.replaceWith() and frame.src = null.

The complete attribute is read-only

from turbo.

I'll work up a little example if I can replicate the behaviour, definitely yep.

Hmm, the intention is not to reload the frame but to cause it to reset back to what it was before it was fetched, so when the element becomes visible again, it will trigger the fetch again.

from turbo.

There's a better way to accomplish the same thing. Check this example:

<a href="/menu" popovertarget="menu" data-turbo-frame="menu" role="button">Menu</a>
<turbo-frame id="menu" popover></turbo-frame>

Each time you click on the link, the Turbo frame will reload from the URL/menu. If you click outside or press escape, the menu will close automatically thanks to the popover attribute.

from turbo.