Code Monkey home page Code Monkey logo

Comments (3)

vaklinov avatar vaklinov commented on September 27, 2024

There are several parts to this issue:

One is an enhancement request: "something that said how much the total transaction was going to be before sending it on both transparent and shielded transactions." It is indeed a good idea. The BitcoinQT core wallet for instance shows the details of the transaction in a dialog box and asks the user if he is sure he wants to send the transaction. The same could be done for the ZEN wallet..

Another part has to do with errors reported when low transaction fees are used. Such errors come from the ZEN node itself. Examples:

Sending a transaction with a non-zero fee and zero amount is not possible:

zen-cli z_sendmany zc8MXGgzRTvkw3RbBGihv59StE1BhmLKK54pTXSgRWcokC93owi1nvpxdwFpqXy2jZ1p1Nz9dZKnBd13KeuTNLLks5DCAAP [{"address":"zceSqZ5Sd99LTy5RMYCHSdjDPJS5EqVBB2Ld73ba3aCuS9Muky2zGxnT9eeH67wbzNdEZTRBMLXKCGxHdXRAc12be5Mcm8p","memo":"54455354","amount":0.00}] 1 0.00001
... 
[AWT-EventQueue-0] [Tue Aug 01 23:25:44 EEST 2017] [ERROR] Unexpected error:  
com.vaklinov.zcashui.ZCashClientCaller$WalletCallException: Error response from wallet: error code: -8
error message:
Fee 0.00001 is greater than the sum of outputs 0.00

The error is reported by the ZEN node - the GUI wallet cannot do anything about it.

Attempting to zend a Z->Z transaction with zero fee and zero amount also produces an error:

zen-cli z_sendmany zc8MXGgzRTvkw3RbBGihv59StE1BhmLKK54pTXSgRWcokC93owi1nvpxdwFpqXy2jZ1p1Nz9dZKnBd13KeuTNLLks5DCAAP [{"address":"zcMeDN38eS3ydUXQsmqQ1UJ9nvpksXrGL92x31SJd4ekj4JWuobr8pi9eR9dtxfhYggXSGpopVefVZDmjxCbzWdwKd7QoHo","memo":"544553543434","amount":0.00}] 1 0.00. 
[AWT-EventQueue-0] [Tue Aug 01 23:29:42 EEST 2017] [INFO] Sending cash with the following command: /home/ivan/workspaces/ZENCashGit1/zen/src/zen-cli z_sendmany zc8MXGgzRTvkw3RbBGihv59StE1BhmLKK54pTXSgRWcokC93owi1nvpxdwFpqXy2jZ1p1Nz9dZKnBd13KeuTNLLks5DCAAP [{"address":"zcMeDN38eS3ydUXQsmqQ1UJ9nvpksXrGL92x31SJd4ekj4JWuobr8pi9eR9dtxfhYggXSGpopVefVZDmjxCbzWdwKd7QoHo","memo":"544553543434","amount":0.00}] 1 0.00. Got result: [opid-42018389-18d5-4016-acd8-64d6a0a2b4be
] 
[Thread-52779] [Tue Aug 01 23:29:42 EEST 2017] [INFO] Operation opid-42018389-18d5-4016-acd8-64d6a0a2b4be status is [{"id":"opid-42018389-18d5-4016-acd8-64d6a0a2b4be","status":"failed","creation_time":1501619382,"error":{"code":-4,"message":"Missing hex data for raw transaction"},"method":"z_sendmany","params":{"fromaddress":"zc8MXGgzRTvkw3RbBGihv59StE1BhmLKK54pTXSgRWcokC93owi1nvpxdwFpqXy2jZ1p1Nz9dZKnBd13KeuTNLLks5DCAAP","amounts":[{"address":"zcMeDN38eS3ydUXQsmqQ1UJ9nvpksXrGL92x31SJd4ekj4JWuobr8pi9eR9dtxfhYggXSGpopVefVZDmjxCbzWdwKd7QoHo","memo":"544553543434","amount":0.00}],"minconf":1,"fee":0}}]. 

Again the error is reported by the ZEN node - the GUI wallet cannot do anything about it.

Interestingly a T->Z transaction with zero fee and zero amount succeeds ;-) in the long run however miners will probably reject transactions with zero/low fees...

from zencash-swing-wallet-ui.

vaklinov avatar vaklinov commented on September 27, 2024

Successful T->Z transaction with zero fee and zero amount:
0_transaction

Log excerpt:

[AWT-EventQueue-0] [Tue Aug 01 23:38:50 EEST 2017] [INFO] The following send command will be issued: /home/ivan/workspaces/ZENCashGit1/zen/src/zen-cli z_sendmany znW67KeSTfWGtBAJTCU9q4b3qSx1xudxbtc [{"address":"zcMeDN38eS3ydUXQsmqQ1UJ9nvpksXrGL92x31SJd4ekj4JWuobr8pi9eR9dtxfhYggXSGpopVefVZDmjxCbzWdwKd7QoHo","memo":"544553543535","amount":0.00}] 1 0.00. 
[AWT-EventQueue-0] [Tue Aug 01 23:38:50 EEST 2017] [INFO] Sending cash with the following command: /home/ivan/workspaces/ZENCashGit1/zen/src/zen-cli z_sendmany znW67KeSTfWGtBAJTCU9q4b3qSx1xudxbtc [{"address":"zcMeDN38eS3ydUXQsmqQ1UJ9nvpksXrGL92x31SJd4ekj4JWuobr8pi9eR9dtxfhYggXSGpopVefVZDmjxCbzWdwKd7QoHo","memo":"544553543535","amount":0.00}] 1 0.00. Got result: [opid-f80d4ece-5513-4f3e-9ec1-a8c11100a129] 
...
[AWT-EventQueue-0] [Tue Aug 01 23:41:10 EEST 2017] [INFO] Operation opid-f80d4ece-5513-4f3e-9ec1-a8c11100a129 status is [{"id":"opid-f80d4ece-5513-4f3e-9ec1-a8c11100a129","status":"success","creation_time":1501619930,"result":{"txid":"5ff021c89cbec55fdebec75d933c4c6f39bc8f4d48fb3ba51f5d4717cfa827ba"},"execution_secs":137.638562411,"method":"z_sendmany","params":{"fromaddress":"znW67KeSTfWGtBAJTCU9q4b3qSx1xudxbtc","amounts":[{"address":"zcMeDN38eS3ydUXQsmqQ1UJ9nvpksXrGL92x31SJd4ekj4JWuobr8pi9eR9dtxfhYggXSGpopVefVZDmjxCbzWdwKd7QoHo","memo":"544553543535","amount":0.00}],"minconf":1,"fee":0}}]. 

from zencash-swing-wallet-ui.

Sto1cNate avatar Sto1cNate commented on September 27, 2024

@zennermac should be able to close this one.

from zencash-swing-wallet-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.