Docker issues with directory flepimop vs flepiMoP vs flepiMoP/flepimop about flepimop HOT 6 CLOSED

We briefly discussed that with @kjsato, we should put the docker folder in another place. The packages in the docker are there but should not be used (as the user install them with local_install.R).

Agree we should not rely on case (e.g MacOS filesystem is not case-sensitive by default).

from flepimop.

In a system context, the advantage of using different naming is that it's easier to recognize whether it's a module directory name or a repository name. But that's not a big deal from the user's point of view (users don't care). In addition, the repo name does not intervene in the behavior within docker, and it is used by copying it to the local dir as the execution environment, so it doesn't matter what the repo name is. It is not the docker environment that you have to worry about PATH, but rather the usage in the local PC environment. In conclusion, is flepiMoP/flepiMoP better or flepiMoP/flepimop better? From the engineer's point of view, the latter is useful for identifying problems but it's okay to adopt the formar.

from flepimop.

from flepimop.

The two issues I see discussed:

1. the code structure which as flepiMoP/flepimop, which I think it's fine (works with non case sensitive systems, and relatively standard). But I'm not strongly against renaming the repo from flepiMoP to flepimop.
2. There is a directory already named flepimop in the docker. I think this directory was meant to act as the old covidsp folder (a place we're to clone the github repo, and as a way to link the local filesystem to the docker one). I believe it should be renamed.

from flepimop.

on 1, agreed. And renaming the repo is not needed.

on 2, agreed if someone wants to use the docker in their accustomed fashion, and there is a problem. That should be modified.

I should denote one thing, the current docker has already involved flepmop (not flepiMoP sorry) and when invoked the docker, it can be configured and used with the condition after finished local_install.R automatically without mounting library dir( in the same manner of covidsp), in considering automation. What I want to say is there are many options we can use.

from flepimop.

Fixed.

from flepimop.