Code Monkey home page Code Monkey logo

Comments (3)

hooram avatar hooram commented on May 18, 2024

I absolutely agree that this should be the case. I merged your PR that tries to parse the timestamp from the filename. Thanks for it. As for what to do with photos without a timestamp, I think option 1 would be a better choice. We can add a separate menu on the front end that lets you see photos without metadata.

from ownphotos.

arthurdk avatar arthurdk commented on May 18, 2024

Hey! Thanks for the 2 merges!

As for this issue. Do you mean a separate menu included in the main one or just another one directly on the Browse/AlbumByDays pages? I think the latter would be better in terms of user experience.

In terms of implement we can choose to make

  1. the date field of the AlbumDate class nullable, which would be quite simple and allow to show the "Unknown" album on the frontend without any changes
  2. Another API path for retrieving pics without metadata (unsure this is good idea honestly)

Anyway thanks for answering, I plan on contributing quite a lot on this project as I'm in a need of a Google Photos replacement and this seems to be a perfect fit. I'll add issues, features request and PR in the coming days.

from ownphotos.

hooram avatar hooram commented on May 18, 2024

Fixed

from ownphotos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.