test-bot shouldn't skip new formulae on ARM CI about homebrew-test-bot HOT 3 CLOSED

But we'd need the HOMEBREW_NEW_FORMULA environment variable to be set for new formulae for this to work. Presumably, this can be done in the same way HOMEBREW_REQUIRE_BOTTLED_ARM is set.

Can we use new_formula = @added_formulae.include?(formula_name)? (from line 598, we'll need to move it up):

from homebrew-test-bot.

Here's one idea:

diff --git a/lib/tests/formulae.rb b/lib/tests/formulae.rb
index a9ec56b..3a17787 100644
--- a/lib/tests/formulae.rb
+++ b/lib/tests/formulae.rb
@@ -580,7 +580,7 @@ module Homebrew
            !formula.bottled? &&
            !formula.bottle_unneeded?
           opoo "#{formula.full_name} has not yet been bottled on ARM!"
-          skip formula.name
+          skip formula.name unless ENV["HOMEBREW_NEW_FORMULA"]
           return
         end 

But we'd need the HOMEBREW_NEW_FORMULA environment variable to be set for new formulae for this to work. Presumably, this can be done in the same way HOMEBREW_REQUIRE_BOTTLED_ARM is set.

Thoughts, @MikeMcQuaid?

Edit: Wait, no, this is totally wrong. Never mind. I think that's better?

from homebrew-test-bot.

Great suggestion; I was looking for where test-bot figured out whether a formula was new. (Not hard enough, it seems.) I'll open a PR for this.

from homebrew-test-bot.