Comments (7)
reitermarkus
commented on August 27, 2024
I guess we can either fix brew bundle to include the frozen_string_literal comment in Brewfiles or change the .rubocop.yml to exclude Brewfile.
from homebrew-test-bot.
MikeMcQuaid
commented on August 27, 2024
Yes, either seems acceptable to me. Closing this as I don't consider this a test-bot issue but we'd review a PR for this!
from homebrew-test-bot.
danielbayley
commented on August 27, 2024
I guess we can either fix
brew bundleto include thefrozen_string_literalcomment inBrewfiles or change the.rubocop.ymlto excludeBrewfile.
@reitermarkus The latter seems like the simpler option, given that the second batch of errors relating to mas app ids would still be an issue… Ideally just those 2 rules would be disabled for Brewfiles… is that not possible?
from homebrew-test-bot.
reitermarkus
commented on August 27, 2024
Ideally just those 2 rules would be disabled for
Brewfiles… is that not possible?
Yes.
from homebrew-test-bot.
danielbayley
commented on August 27, 2024
Ok, sounds simple enough then. I'll try a [hopefully] quick PR…
@reitermarkus @MikeMcQuaid Am I right in thinking it's one of these .rubocop*.ymls?
from homebrew-test-bot.
reitermarkus
commented on August 27, 2024
Yes, the plain one, .rubocop.yml.
from homebrew-test-bot.
danielbayley
commented on August 27, 2024
@reitermarkus @MikeMcQuaid Just passed all checks in Homebrew/brew#9169 👍
from homebrew-test-bot.
Related Issues (20)
- Dependent formula is not build with `--build-dependents-from-source` when running test-bot HOT 3
- Error treating custom/tap/formula as a formula when there is a cask with the same name HOT 14
- Behavior change in building bottles against bottles from previous macOS versions HOT 13
- Annotations and ignore logic not working on Linux HOT 12
- Split bottling and testing a formula into separate steps HOT 13
- `git -C "${HOMEBREW_REPOSITORY}" clean` failed in `brew test-bot --only-cleanup-after` HOT 1
- Option to skip building unbottled dependents from source HOT 3
- Build bottles for arm64 HOT 1
- error in tap CI: brew link m4
- test-bot exiting on failure with success code HOT 2
- max number of concurrent jobs HOT 1
- Build failure due to deleted `etc` files from built dependencies HOT 1
- Don't skip if "has dependencies without compatible bottles" only affects `:build` dependencies HOT 6
- Bottles published but revision not merged HOT 5
- Cask was detected as formula with `--only-formulae` HOT 12
- `--only-formulae-detect` should work inside `merge_group` events HOT 1
- Tap CI failing on `brew test-bot --only-formulae` on Linux HOT 6
- gpsim 0.32.0 bottle issue HOT 5
- `brew test-bot --only-formulae` fails with a parsing error
- Errors resulting from `--new-formula` deprecation HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from homebrew-test-bot.