Comments (16)
mmastrac
commented on June 20, 2024
2
I found some UB in deno_core that is likely causing this. Rust 1.78 seems to have been the trigger for it to start failing, but the code was certainly busted for a while.
This should be fixed in 1.43.3.
from homebrew-core.
mmastrac
commented on June 20, 2024
1
Minimal repro:
deno eval "fetch('http://8.8.8.8')"
from homebrew-core.
carlocab
commented on June 20, 2024
1
Not quite fixed yet. Merged PR is merely a workaround.
from homebrew-core.
carlocab
commented on June 20, 2024
1
Should be fixed in #171423 which will merge shortly.
Do brew update && brew upgrade deno in about 20 minutes or so.
from homebrew-core.
mmastrac
commented on June 20, 2024
(lldb) bt
* thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
* frame #0: 0x00000001965467fc libsystem_platform.dylib`_platform_memmove + 444
frame #1: 0x00000001003b1134 deno`_$LT$alloc..string..String$u20$as$u20$core..fmt..Write$GT$::write_str::h0cd0257f8894a894 (.78) + 60
frame #2: 0x000000010048879c deno`core::fmt::write::hef5cddb56c038e23 + 412
frame #3: 0x00000001011385d4 deno`_$LT$serde_v8..error..Error$u20$as$u20$core..fmt..Display$GT$::fmt::h6d6357bd95d56e19 + 788
frame #4: 0x000000010048879c deno`core::fmt::write::hef5cddb56c038e23 + 412
frame #5: 0x00000001003cceb0 deno`anyhow::error::_$LT$impl$u20$core..fmt..Display$u20$for$u20$anyhow..Error$GT$::fmt::hc813d512ad8949cb + 96
frame #6: 0x000000010048879c deno`core::fmt::write::hef5cddb56c038e23 + 412
frame #7: 0x00000001003b1088 deno`alloc::fmt::format::format_inner::hcf93ae4763afd4b5 + 296
frame #8: 0x0000000100cf8240 deno`deno_fetch::op_fetch::op_fetch$LT$FP$GT$::v8_fn_ptr::h86e6e97f373d448e + 188
frame #9: 0x00000001025fef98 deno`Builtins_CallApiCallbackGeneric + 184
frame #10: 0x00000001025fcef0 deno`Builtins_InterpreterEntryTrampoline + 272
frame #11: 0x00000001025fcef0 deno`Builtins_InterpreterEntryTrampoline + 272
frame #12: 0x00000001027023a0 deno`Builtins_PromiseConstructor + 2400
frame #13: 0x00000001025fdc78 deno`construct_stub_invoke_deopt_addr + 256
frame #14: 0x0000000102773270 deno`Builtins_ConstructHandler + 880
frame #15: 0x00000001025fcef0 deno`Builtins_InterpreterEntryTrampoline + 272
frame #16: 0x00000001025fcef0 deno`Builtins_InterpreterEntryTrampoline + 272
frame #17: 0x000000010263b5a4 deno`Builtins_GeneratorPrototypeNext + 132
frame #18: 0x00000001025fac0c deno`Builtins_JSEntryTrampoline + 172
frame #19: 0x00000001025fa8f4 deno`Builtins_JSEntry + 148
frame #20: 0x0000000101609730 deno`v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) + 1608
frame #21: 0x0000000101609fa0 deno`v8::internal::(anonymous namespace)::InvokeWithTryCatch(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) + 88
frame #22: 0x000000010160a06c deno`v8::internal::Execution::TryCall(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*, v8::internal::Execution::MessageHandling, v8::internal::MaybeHandle<v8::internal::Object>*) + 120
frame #23: 0x00000001019a0b68 deno`v8::internal::SourceTextModule::ExecuteModule(v8::internal::Isolate*, v8::internal::Handle<v8::internal::SourceTextModule>, v8::internal::MaybeHandle<v8::internal::Object>*) + 156
frame #24: 0x00000001019a0354 deno`v8::internal::SourceTextModule::InnerModuleEvaluation(v8::internal::Isolate*, v8::internal::Handle<v8::internal::SourceTextModule>, v8::internal::ZoneForwardList<v8::internal::Handle<v8::internal::SourceTextModule>>*, unsigned int*) + 968
frame #25: 0x000000010199fe4c deno`v8::internal::SourceTextModule::Evaluate(v8::internal::Isolate*, v8::internal::Handle<v8::internal::SourceTextModule>) + 232
frame #26: 0x000000010196e96c deno`v8::internal::Module::Evaluate(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Module>) + 272
frame #27: 0x0000000101515474 deno`v8::Module::Evaluate(v8::Local<v8::Context>) + 540
frame #28: 0x00000001005653b0 deno`deno_core::modules::map::ModuleMap::mod_evaluate::hf44916c1c16b2045 + 528
frame #29: 0x00000001005e4308 deno`deno_core::runtime::jsruntime::JsRuntime::mod_evaluate::h0e07d500fdf7e313 + 60
frame #30: 0x00000001000f8358 deno`deno::worker::CliMainWorker::evaluate_module_possibly_with_npm::_$u7b$$u7b$closure$u7d$$u7d$::hf71662aaf868eee2 + 364
frame #31: 0x0000000100145328 deno`deno::worker::CliMainWorker::execute_main_module_possibly_with_npm::_$u7b$$u7b$closure$u7d$$u7d$::hba55f853210870e4 + 832
frame #32: 0x00000001001446a4 deno`deno::worker::CliMainWorker::run::_$u7b$$u7b$closure$u7d$$u7d$::h7173fcd5639f5c51 + 1108
frame #33: 0x000000010033a4fc deno`deno::spawn_subcommand::_$u7b$$u7b$closure$u7d$$u7d$::hcbe870bd72885b6e + 924
frame #34: 0x0000000100379d70 deno`_$LT$deno_unsync..task..MaskFutureAsSend$LT$F$GT$$u20$as$u20$core..future..future..Future$GT$::poll::h9df2cefee1c7d85b + 40
frame #35: 0x000000010037a078 deno`tokio::runtime::task::raw::poll::heefa63eb0fc35a17 + 88
frame #36: 0x0000000100013b8c deno`deno::main::h2177c5e647eb4673 + 4560
frame #37: 0x0000000100006cb4 deno`std::sys_common::backtrace::__rust_begin_short_backtrace::hf003e1d37bf08e70 + 12
frame #38: 0x0000000100012734 deno`main + 656
frame #39: 0x00000001961bff28 dyld`start + 2236
from homebrew-core.
Bo98
commented on June 20, 2024
The only difference I can see is that we updated Rust to 1.78.0 in the interim. Perhaps Deno has issues with Rust 1.78?
We don't ship Rust 1.77 anymore so will need to figure out a fix for 1.78 if so.
from homebrew-core.
mmastrac
commented on June 20, 2024
We're unfortunately blocked on 1.78 (EDIT: to clarify, blocked on upgrading to 1.78) on the deno side because of an LLVM-18 issue (the current packages don't include the linker) so we haven't done any testing there yet.
I'm not sure but we might be able to build Mac on 1.78 and Linux on 1.77 for now to see if it repros on our end.
from homebrew-core.
jerome-benoit
commented on June 20, 2024
We're unfortunately blocked on 1.78 on the deno side because of an LLVM-18 issue (the current packages don't include the linker) so we haven't done any testing there yet.
You mean 1.77, right?
from homebrew-core.
chenrui333
commented on June 20, 2024
the downgrade to 1.43.1 works fine for me (with the fresh test, which failed with 1.43.2)
$ clang --version
Homebrew clang version 18.1.5
Target: arm64-apple-darwin23.4.0
Thread model: posix
InstalledDir: /opt/homebrew/Cellar/llvm/18.1.5/bin
$ rustc --version
rustc 1.78.0 (9b00956e5 2024-04-29) (Homebrew)
$ brew test -d -v deno
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.1.0/bin/bundle clean
/opt/homebrew/Library/Homebrew/brew.rb (Formulary::FromNameLoader): loading deno
/opt/homebrew/Library/Homebrew/brew.rb (Formulary::FromTapLoader): loading homebrew/core/deno
/opt/homebrew/Library/Homebrew/brew.rb (Formulary::FromNameLoader): loading cmake
/opt/homebrew/Library/Homebrew/brew.rb (Formulary::FromNameLoader): loading llvm
/opt/homebrew/Library/Homebrew/brew.rb (Formulary::FromNameLoader): loading ninja
/opt/homebrew/Library/Homebrew/brew.rb (Formulary::FromNameLoader): loading protobuf
/opt/homebrew/Library/Homebrew/brew.rb (Formulary::FromNameLoader): loading rust
/opt/homebrew/Library/Homebrew/brew.rb (Formulary::FromNameLoader): loading sqlite
==> Testing deno
/opt/homebrew/Library/Homebrew/test.rb (Formulary::FromPathLoader): loading /opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/d/deno.rb
==> /opt/homebrew/Cellar/deno/1.43.1/bin/deno run hello.ts
==> /opt/homebrew/Cellar/deno/1.43.1/bin/deno run https://deno.land/[email protected]/examples/welcome.ts
/opt/homebrew/Library/Homebrew/test.rb (Formulary::FromNameLoader): loading sqlite
also I can reproduce this with deno 1.43.2, but not with deno 1.43.1
$ deno eval "fetch('http://8.8.8.8')"
Segmentation fault: 11
from homebrew-core.
mmastrac
commented on June 20, 2024
You mean 1.77, right?
No, we can't upgrade to 1.78 for Linux builds because our sysroot build fails using the llvm-17 package we install from apt.llvm.org.
Bug is here: denoland/deno#23676
Upstream LLVM issue here: llvm/llvm-project#87553
from homebrew-core.
jerome-benoit
commented on June 20, 2024
You mean 1.77, right?
No, we can't upgrade to 1.78 for Linux builds because our sysroot build fails using the llvm-17 package we install from apt.llvm.org.
That's what you mean but wrote 1.78 (typo) ;). Nevermind, explanations are clear.
from homebrew-core.
carlocab
commented on June 20, 2024
As a workaround:
brew tap --force homebrew/core
cd "$(brew --repository homebrew/core)"
git checkout bf2314dc93067e2c6dd108279244ac3740b568e6
HOMEBREW_NO_INSTALL_FROM_API=1 brew install deno
git checkout master
# skip the command below if you contribute to homebrew/core
brew untap homebrew/corefrom homebrew-core.
mmastrac
commented on June 20, 2024
Here's what appears to be happening:
- Some fairly old (~2yrs+) code was using a bit of a sketchy reference -> pointer -> u64 conversion to values that were live on the stack (!). This is definitely bad.
- This worked fine in 1.77, even passing valgrind tests!
- This code breaks in Rust 1.78, likely because some of the types that were being passed on the stack previously might be in registers now, or might be in stack locations that are overwritten
- We never picked this up in our tests because we're blocked on upgrading to Rust 1.78 and stuck on 1.77 for now. We can, however, bump deno_core up to 1.78 to ensure that we test those parts of the code on the newer compiler.
We're going to fix the UB here by boxing the values. It's a band-aid fix but we consider this code to be EOL and we're actively working on replacing it.
from homebrew-core.
mmastrac
commented on June 20, 2024
Deno 1.43.3 incoming -- should fix this issue.
from homebrew-core.
jerome-benoit
commented on June 20, 2024
The deno formula downgrade to 1.43.1 is not installed over installed 1.43.2 formula:
Warning: Skipping deno: most recent version 1.43.1 not installed
from homebrew-core.
carlocab
commented on June 20, 2024
Yes, #171382 was just meant to prevent more users from upgrading to a broken build. If you've already done so, you need to do brew reinstall deno.
from homebrew-core.
Related Issues (20)
- docker-py not working with docker 7.0.0 in ansible formula HOT 1
- Problem with ansible-lint formula HOT 8
- [email protected] fails to install in GitHub runner image HOT 8
- curl 8.8.0 - problem with `--write-out`: error 43 - A libcurl function was given a bad argument HOT 15
- brew install --cask metasploit fail 404 on macOS HOT 1
- psql segfaults from brew linked krb5 HOT 4
- mtr doesn't gives any report output if --port option is used with tcp/ udp. HOT 1
- virt-manager will only run if run with --debug flag HOT 2
- Podman recipe requires `pasta` now as well, or extra configuration to avoid needing `pasta` HOT 1
- gitg: SHA256 mismatch HOT 3
- Including .ruby-version in homebrew-core can force ruby version for Ruby scripts in /opt/homebrew/bin HOT 3
- Conflicting Instructions for Using Homebrew-installed LLVM HOT 1
- `universal-ctags` continuously upgrade to the same version HOT 1
- package ccze not picked up by install command HOT 1
- swi-prolog installed with --HEAD option shows different versions HOT 1
- Missing msbuild in [email protected] breaks SonarQube scanning in our build pipeline HOT 1
- Running formulae `asitop` breaks `[email protected]` permissions HOT 3
- Homebrew curl HTTP/3 support HOT 4
- brew install scikit-image isn't importable from python3.12 HOT 2
- autopsy is not the latest version HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from homebrew-core.