Code Monkey home page Code Monkey logo

Comments (3)

SMillerDev avatar SMillerDev commented on May 24, 2024 1

Upstream changing their mind isn't really a bug so I'm closing this. I'm happy to review a pull request that re-adds the features you requested.

from homebrew-core.

ewenmcneill avatar ewenmcneill commented on May 24, 2024

Reporting via the "bug" path, since this is a regression. Although to be fair it's basically an upstream regression (they moved several image formats out of "built by default", apparently in a minor release -- 2.42.11 AFAICT).

Upstream commit that disabled xpm by default:

https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/commit/e052a112075a19fb75f1f2ff3de4c82923de13f2

Arch Linux work around for the same issue (with another application using xpm icons):

https://gitlab.archlinux.org/archlinux/packaging/packages/gdk-pixbuf2/-/commit/4fa2d98a197781354b66a9710c9d596d502c961b

(AFAICT they enabled -D others=enabled)

Of the ones now in "others" (and off by default in gdk-pixbuf 2.42.11 upstream) probably at least xpm (X11 icons) and bmp (Windows) are still fairly common image formats.

Can we either follow the Arch Linux approach and re-enable these image formats that were supported by default up through 2.4.10, or at least re-enable support for xpm specifically?

Thanks,

Ewen

from homebrew-core.

ewenmcneill avatar ewenmcneill commented on May 24, 2024

For certainty, adding-Dothers=enabled and locally rebuilding gdk-pixbuf from source does solve this problem.

ewen@basadi:~$ brew edit gdk-pixbuf
Editing /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/g/gdk-pixbuf.rb
ewen@basadi:~$ (cd /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/g && git diff)
diff --git a/Formula/g/gdk-pixbuf.rb b/Formula/g/gdk-pixbuf.rb
index db5572ad57f..0c2ff128b5d 100644
--- a/Formula/g/gdk-pixbuf.rb
+++ b/Formula/g/gdk-pixbuf.rb
@@ -57,6 +57,7 @@ class GdkPixbuf < Formula
                                       "-Dpng=enabled",
                                       "-Dtiff=enabled",
                                       "-Djpeg=enabled",
+                                      "-Dothers=enabled",
                                       "-Dintrospection=enabled",
                                       *std_meson_args
     system "meson", "compile", "-C", "build", "--verbose"
ewen@basadi:~$ HOMEBREW_NO_INSTALL_FROM_API=1 brew reinstall -s gdk-pixbuf
Warning: building from source is not supported!
You're on your own. Failures are expected so don't create any issues, please!
==> Fetching gdk-pixbuf
==> Downloading https://download.gnome.org/sources/gdk-pixbuf/2.42/gdk-pixbuf-2.42.11.tar.xz
Already downloaded: /Users/ewen/Library/Caches/Homebrew/downloads/a17874134e1e91119bee6856875310cf072750427384985ce3320d1cdc29467a--gdk-pixbuf-2.42.11.tar.xz
==> Reinstalling gdk-pixbuf 
==> meson setup build -Drelocatable=false -Dnative_windows_loaders=false -Dtests=false -Dinstalled_tests=false -Dman=true -Dgtk_doc=false -Dpng=enabled -Dtiff=enabled -Djpeg=enabled -Dothers=enabled -Dintrospection=enabled
==> meson compile -C build --verbose
==> meson install -C build
==> /usr/local/Cellar/gdk-pixbuf/2.42.11/bin/gdk-pixbuf-query-loaders --update-cache
🍺  /usr/local/Cellar/gdk-pixbuf/2.42.11: 151 files, 3.8MB, built in 25 seconds
==> Running `brew cleanup gdk-pixbuf`...
ewen@basadi:~$ 
ewen@basadi:/tmp/gdkpixbuf$ ./testxpm
ewen@basadi:/tmp/gdkpixbuf$ 

and FTR the jpilot application I was trying to run now starts properly with this local build of gdk-pixbuf, temporarily working around my issue.

It would be helpful if this could be enabled in the default gdk-pixbuf build, as Arch Linux did. (Or at least something like -Dxpm=enabled, which was built by default prior to gdk-pixbuf 2.42.11. ETA: looking closer I'm not sure there is an xpm option, just an others option, at present.)

Ewen

from homebrew-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.