Code Monkey home page Code Monkey logo

Comments (20)

joostlek avatar joostlek commented on June 28, 2024 1

I only know code wise, i dont have any device myself

from core.

home-assistant avatar home-assistant commented on June 28, 2024

Hey there @swcloudgenie, mind taking a look at this issue as it has been labeled with an integration (aladdin_connect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of aladdin_connect can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign aladdin_connect Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


aladdin_connect documentation
aladdin_connect source
(message by IssueLinks)

from core.

swcloudgenie avatar swcloudgenie commented on June 28, 2024

Is this perhaps an older version of Home Assistant? The new version does not require OAuth credentials, it should take the user directly to the login page.

from core.

swcloudgenie avatar swcloudgenie commented on June 28, 2024

I have tested this locally from the dev branch, and I am not asked for OAuth credentials. These credentials are stored in the cloud. Is it possible this integration was not able to connect to the HA cloud, and this was a fallback?

Either way, we cannot release these OAuth credentials, they must come from the HA cloud.

from core.

missedtheapex avatar missedtheapex commented on June 28, 2024

Does that mean this integration is only available with the paid HA Cloud? That's not clear from the documentation...mainly because there is no updated documentation.

Will there not be an option for a manual workaround, as is the case with many other integrations? Seems that being able to use the phone app or a website to get API credentials for my account would allow the integration to work as-is. That's a common method for many other services.

from core.

swcloudgenie avatar swcloudgenie commented on June 28, 2024

Does that mean this integration is only available with the paid HA Cloud? That's not clear from the documentation...mainly because there is no updated documentation.

Will there not be an option for a manual workaround, as is the case with many other integrations? Seems that being able to use the phone app or a website to get API credentials for my account would allow the integration to work as-is. That's a common method for many other services.

No, this is available without the paid account. I have tested this myself without the paid account, and I am directed to the login page without any request for OAuth credentials. Are there any error/warning logs from the integration before you reach this screen? I am not familiar with the inner workings of the auth flow, but I am wondering if this is a fallback mechanism.

from core.

joostlek avatar joostlek commented on June 28, 2024

@swcloudgenie you implemented a oauth flow, that means users have to fill in aouth client id and secret. They are stored in https://my.home-assistant.io/redirect/application_credentials/

from core.

missedtheapex avatar missedtheapex commented on June 28, 2024

Are there any error/warning logs from the integration before you reach this screen?

None at all. That dialog is the only thing that appears after clicking "Add Integration" and selecting AC. Nothing shows up in the log, either from the AC integration or from HA in general.

Sounds like @joostlek knows something, which might be helpful because we've exceeded my non-dev understanding of how to implement these things.

from core.

swcloudgenie avatar swcloudgenie commented on June 28, 2024

@swcloudgenie you implemented a oauth flow, that means users have to fill in aouth client id and secret. They are stored in https://my.home-assistant.io/redirect/application_credentials/

The OAuth credentials are stored on Home Assistant side. We cannot release these credentials to end users. I have tested this on my own installation without the credentials and it works okay.

from core.

joostlek avatar joostlek commented on June 28, 2024

Did you see anything in the application credentials page on your instance?

from core.

swcloudgenie avatar swcloudgenie commented on June 28, 2024

Did you see anything in the application credentials page on your instance?

I was never taken to the application credentials page from the screenshot above. As soon as I initiate the setup, I am taken directly to the AladdinConnect login page.

from core.

joostlek avatar joostlek commented on June 28, 2024

I sent a link which takes you there

from core.

missedtheapex avatar missedtheapex commented on June 28, 2024

Did you see anything in the application credentials page on your instance?

Me? No. I only have one entry in my Application Credentials, and it's for another integration. Nothing for Aladdin.

And I can't see why there would be, since at no point did HA or the Aladdin integration ask me for my Genie account info. Maybe it would have if I still had things saved from the old integration? But I wiped that out months ago.

So unlike @swcloudgenie, I'm not being taken to a login page and I'm not sure why. Can confirm this is true whether I use my laptop browser or the HA iOS app to try an add the integration.

from core.

swcloudgenie avatar swcloudgenie commented on June 28, 2024
image image

This is what happens when I add it on my end. As soon as I click on Aladdin Connect, I am taken to the external login screen

from core.

joostlek avatar joostlek commented on June 28, 2024

@swcloudgenie, please click the link I sent and go to the application credentials screen on your instance

from core.

swcloudgenie avatar swcloudgenie commented on June 28, 2024

@joostlek here is that screen on my instance:

image

from core.

missedtheapex avatar missedtheapex commented on June 28, 2024

Update:

I spooled up a start-from-scratch Home Assistant install on a fresh VM. I used a Docker image since that's what my main installation is, too. When I loaded that HA instance, adding the Aladdin Connect integration pops up a login window in my browser to get my username/password. In short, that works as expected.

But my active installation still doesn't cooperate. I changed my Docker image tag from "stable" to "dev" to get as updated an image as possible. Even then, it doesn't create the same login screen, it just has the HA dialog for OAuth credentials.

My HA install is years old and could be carrying any number of legacy configuration "nuances" that might interfere. Maybe the biggest difference between this and my test container is that my real HA instance sits behind a reverse proxy (nginx) and has a let's encrypt certificate for a custom domain. But there could be a hundred other things...and unfortunately nothing shows up in the logs to help.

So it appears to be a "me" problem, but it might be something that affects a whole class of users in specific circumstances.

from core.

missedtheapex avatar missedtheapex commented on June 28, 2024

Final Update:

I figured out that I did not have the Cloud enabled in my ancient configuration.yaml. After adding the cloud: line and restarting HA, I was able to get the Aladdin Connect login screen and added the integration successfully.

Hopefully if anyone else has a similar problem, they'll find this and save themselves some time.

Sorry for the confusion! I guess I need to take some quality time and rebuild my HA instance one of these days...it's held together with duct tape and bubble gum at this point.

from core.

joostlek avatar joostlek commented on June 28, 2024

sorry @swcloudgenie you were right, we did get them from the cloud.

What this means is that you need to have either default_config: or cloud: in your configuration.yaml to be able to login

from core.

mkmer avatar mkmer commented on June 28, 2024

I was seeing this same situation in the beta test. Default was enabled in the standard, and sometimes it went to the creds, sometimes it went to the oauth web site. There may be something more than the configuration causing the dialog to appear, but I couldn't get it to repeat for debug. Maybe a race in the async stuff?

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.