The problem When setting a service target using a label, entities

<div class="highlight highlight-source-diff notranslate position-relative overflow-auto" dir="auto"

Hidden devices excluded from label targeting about core HOT 3 CLOSED

reflectivecode commented on June 7, 2024

Hidden devices excluded from label targeting

from core.

Comments (3)

bdraco commented on June 7, 2024

diff --git a/homeassistant/helpers/service.py b/homeassistant/helpers/service.py
index 66c9f7db3e6..e7ef6fc3223 100644
--- a/homeassistant/helpers/service.py
+++ b/homeassistant/helpers/service.py
@@ -532,10 +532,6 @@ def async_extract_referenced_entity_ids(  # noqa: C901
                 selected.missing_labels.add(label_id)
 
             for entity_entry in entities.get_entries_for_label(label_id):
-                if (
-                    entity_entry.entity_category is None
-                    and entity_entry.hidden_by is None
-                ):
                 selected.indirectly_referenced.add(entity_entry.entity_id)
 
             for device_entry in dev_reg.devices.get_devices_for_label(label_id):

from core.

bdraco commented on June 7, 2024

The existing behavior is consistent with how we do it for areas and devices though so if we want to change it we probably would want to change it everywhere.

I'm inclined to call this by design though

from core.

reflectivecode commented on June 7, 2024

Well, it makes sense that it is consistent. But it seems to make labels difficult to use for hidden entities. I wish there was a configuration option for target like include_hidden.

I guess the workaround is to use a template like this:

alias: Goodbye
sequence:
  - service: homeassistant.turn_off
    data: {}
    target:
      entity_id: "{{ label_entities('automation:goodbye') }}"
mode: single

I'll close my issue since this seems to be by design and I have a workaround.

from core.

Recommend Projects