Code Monkey home page Code Monkey logo

Comments (7)

holly-hacker avatar holly-hacker commented on June 30, 2024 2

Ah yeah, Smoogipoo once made a beatmap library that had this bug. I'll update the parser tomorrow.

from oppaisharp.

holly-hacker avatar holly-hacker commented on June 30, 2024

Yeah the parser is pretty picky, I'll rewrite some parts of it later.

from oppaisharp.

Piotrekol avatar Piotrekol commented on June 30, 2024

Previously all maps from this test suite were failing:

==RANKED==
Total: 2
Passed: 2
Failed: 0
==UNRANKED==
Various Artists - Speed Compilation (Minu) [SLoWMoTIoN 220BPM].osu
Various Artists - Practice Pack (-Element-) [&z 1.1x].osu
Various Artists - Practice Pack (-Element-) [&z 1.2x].osu
Various Artists - Practice Pack (-Element-) [&z 1.3x].osu
Various Artists - Practice Pack (-Element-) [&z 1.4x].osu
Various Artists - Practice Pack (-Element-) [(can you) understand me 1.1x].osu
Various Artists - Practice Pack (-Element-) [(can you) understand me 1.2x].osu
Various Artists - Practice Pack (-Element-) [(can you) understand me 1.3x].osu
Various Artists - Practice Pack (-Element-) [(can you) understand me 1.4x].osu
Various Artists - Practice Pack (-Element-) [7 -seven- 1.1x].osu
Various Artists - Practice Pack (-Element-) [7 -seven- 1.2x].osu
Various Artists - Practice Pack (-Element-) [7 -seven- 1.3x].osu
Various Artists - Practice Pack (-Element-) [7 -seven- 1.4x].osu
Various Artists - Practice Pack (-Element-) [Akatsuki Zukuyo 1.1x].osu
Various Artists - Practice Pack (-Element-) [Akatsuki Zukuyo 1.2x].osu
Various Artists - Practice Pack (-Element-) [Akatsuki Zukuyo 1.3x].osu
Various Artists - Practice Pack (-Element-) [Akatsuki Zukuyo 1.4x].osu
Various Artists - Practice Pack (-Element-) [Amatsu Kitsune 1.2x].osu
Various Artists - Practice Pack (-Element-) [Amatsu Kitsune 1.3x].osu
Various Artists - Practice Pack (-Element-) [Asymmetry 1.1x].osu
Various Artists - Practice Pack (-Element-) [Asymmetry 1.2x].osu
Various Artists - Practice Pack (-Element-) [Asymmetry 1.3x].osu
Various Artists - Practice Pack (-Element-) [Bye Bye YESTERDAY 1.1x].osu
Various Artists - Practice Pack (-Element-) [Bye Bye YESTERDAY 1.2x].osu
Various Artists - Practice Pack (-Element-) [Bye Bye YESTERDAY 1.3x].osu
Various Artists - Practice Pack (-Element-) [Cobalt 1.1x].osu
Various Artists - Practice Pack (-Element-) [Cobalt 1.2x].osu
Various Artists - Practice Pack (-Element-) [Cobalt 1.3x].osu
Various Artists - Practice Pack (-Element-) [Cobalt 1.4x].osu
Various Artists - Practice Pack (-Element-) [DREAM SOLISTER 1.1x].osu
Various Artists - Practice Pack (-Element-) [DREAM SOLISTER 1.2x].osu
Various Artists - Practice Pack (-Element-) [DREAM SOLISTER 1.3x].osu
Various Artists - Practice Pack (-Element-) [DREAM SOLISTER 1.4x].osu
Various Artists - Practice Pack (-Element-) [FIRST 1.1x].osu
Various Artists - Practice Pack (-Element-) [FIRST 1.2x].osu
Various Artists - Practice Pack (-Element-) [FIRST 1.3x].osu
Various Artists - Practice Pack (-Element-) [If You Can't Hang 1.1x].osu
Various Artists - Practice Pack (-Element-) [If You Can't Hang 1.2x].osu
Various Artists - Practice Pack (-Element-) [If You Can't Hang 1.3x].osu
Various Artists - Practice Pack (-Element-) [Itazura Fiction 1.1x].osu
Various Artists - Practice Pack (-Element-) [Itazura Fiction 1.2x].osu
Various Artists - Practice Pack (-Element-) [Itazura Fiction 1.3x].osu
Various Artists - Practice Pack (-Element-) [Itsuwari NEUROSE 1.1x].osu
Various Artists - Practice Pack (-Element-) [Itsuwari NEUROSE 1.2x].osu
Various Artists - Practice Pack (-Element-) [Itsuwari NEUROSE 1.3x].osu
Various Artists - Practice Pack (-Element-) [Kimi o Sagashi ni 1.1x].osu
Various Artists - Practice Pack (-Element-) [Kimi o Sagashi ni 1.2x].osu
Various Artists - Practice Pack (-Element-) [Kimi o Sagashi ni 1.3x].osu
Various Artists - Practice Pack (-Element-) [Kimi o Sagashi ni 1.4x].osu
Various Artists - Practice Pack (-Element-) [Kiss no Hitotsu de 1.1x].osu
Various Artists - Practice Pack (-Element-) [Kiss no Hitotsu de 1.2x].osu
Various Artists - Practice Pack (-Element-) [Kiss no Hitotsu de 1.3x].osu
Various Artists - Practice Pack (-Element-) [Kiss no Hitotsu de 1.4x].osu
Various Artists - Practice Pack (-Element-) [Mahou Shoujo Chino 1.1x].osu
Various Artists - Practice Pack (-Element-) [Mahou Shoujo Chino 1.2x].osu
Various Artists - Practice Pack (-Element-) [Mahou Shoujo Chino 1.3x].osu
Various Artists - Practice Pack (-Element-) [Mahou Shoujo Chino 1.4x].osu
Various Artists - Practice Pack (-Element-) [Miraizu 1.1x].osu
Various Artists - Practice Pack (-Element-) [Miraizu 1.2x].osu
Various Artists - Practice Pack (-Element-) [Miraizu 1.3x].osu
Various Artists - Practice Pack (-Element-) [Miraizu 1.4x].osu
Various Artists - Practice Pack (-Element-) [Missing You 1.1x].osu
Various Artists - Practice Pack (-Element-) [Missing You 1.2x].osu
Various Artists - Practice Pack (-Element-) [Missing You 1.3x].osu
Various Artists - Practice Pack (-Element-) [Missing You 1.4x].osu
Various Artists - Practice Pack (-Element-) [Music Start 1.1x].osu
Various Artists - Practice Pack (-Element-) [Music Start 1.2x].osu
Various Artists - Practice Pack (-Element-) [Music Start 1.3x].osu
Various Artists - Practice Pack (-Element-) [Music Start 1.4x].osu
Various Artists - Practice Pack (-Element-) [My Spirit Will Go On 1.1x].osu
Various Artists - Practice Pack (-Element-) [My Spirit Will Go On 1.2x].osu
Various Artists - Practice Pack (-Element-) [My Spirit Will Go On 1.3x].osu
Various Artists - Practice Pack (-Element-) [My Spirit Will Go On 1.4x].osu
Various Artists - Practice Pack (-Element-) [Pride Kakumei 1.1x].osu
Various Artists - Practice Pack (-Element-) [Sakura Fubuki 1.1x].osu
Various Artists - Practice Pack (-Element-) [Sakura Fubuki 1.2x].osu
Various Artists - Practice Pack (-Element-) [Sakura Fubuki 1.3x].osu
Various Artists - Practice Pack (-Element-) [SAKURA Skip 1.1x].osu
Various Artists - Practice Pack (-Element-) [SAKURA Skip 1.2x].osu
Various Artists - Practice Pack (-Element-) [SAKURA Skip 1.3x].osu
Various Artists - Practice Pack (-Element-) [SAKURA Skip 1.4x].osu
Various Artists - Practice Pack (-Element-) [SANTA SAN 1.1x].osu
Various Artists - Practice Pack (-Element-) [SANTA SAN 1.2x].osu
Various Artists - Practice Pack (-Element-) [Shoujo Satori 1.2x].osu
Various Artists - Practice Pack (-Element-) [Shoujo Satori 1.3x].osu
Various Artists - Practice Pack (-Element-) [SLoWMoTIoN 1.2x].osu
Various Artists - Practice Pack (-Element-) [SLoWMoTIoN 1.3x].osu
Various Artists - Practice Pack (-Element-) [Spiral 1.1x].osu
Various Artists - Practice Pack (-Element-) [Spiral 1.2x].osu
Various Artists - Practice Pack (-Element-) [Spiral 1.3x].osu
Various Artists - Practice Pack (-Element-) [Spiral 1.4x].osu
Various Artists - Practice Pack (-Element-) [Summer Of The Occult 1.1x].osu
Various Artists - Practice Pack (-Element-) [Summer Of The Occult 1.2x].osu
Various Artists - Practice Pack (-Element-) [Summer Of The Occult 1.3x].osu
Various Artists - Practice Pack (-Element-) [Tengoku to Jigoku 1.1x].osu
Various Artists - Practice Pack (-Element-) [Tengoku to Jigoku 1.2x].osu
Various Artists - Practice Pack (-Element-) [Tengoku to Jigoku 1.3x].osu
Various Artists - Practice Pack (-Element-) [Yuki no Youni 1.2x].osu
Various Artists - Practice Pack (-Element-) [Yuki no Youni 1.3x].osu
Various Artists - Practice Pack (-Element-) [Yuki no Youni 1.4x].osu
Total: 141
Passed: 41
Failed: 100

I'll also do a pass on all maps I have later

from oppaisharp.

holly-hacker avatar holly-hacker commented on June 30, 2024

Tell me which ones are failing and I'll update the parser.

from oppaisharp.

holly-hacker avatar holly-hacker commented on June 30, 2024

Make sure you're not running the debug build though, the debug one will crash on bad beatmaps. If you download it from Nuget you will automatically get the proper Release build.

from oppaisharp.

Piotrekol avatar Piotrekol commented on June 30, 2024

Sorry for late response.
out of 46375 osu mode maps only 100 fail where all of them seem to fail because of this line in [TimingPoints] section:
SliderBorder:BMAPI.Colour
sublime_text_2018-02-20_20-54-22
This screams invalid, but osu! doesn't have any issue with it :/

from oppaisharp.

holly-hacker avatar holly-hacker commented on June 30, 2024

Sorry for the wait. Turns out I'm not that great at "tomorrow".

from oppaisharp.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.