hobo / hobo_bootstrap Goto Github PK

In case of a localized app, where you use detault url options ending ?locale=de <dev-user-changer> is broken.

So in my app I patch it according to the definition in hobo_bootstrap / taglibs / nav.dryml by exchanging ?login with &login like so

<def tag="dev-user-changer">
  <set user="&Hobo::Model::UserBase.default_user_model"/>
  <select-menu if="&user && Rails.env.development?"
               first-option="#{t('hobo.dev_user_changer.guest', {:default=>'Guest'})}" options="&user.all(:limit => 30).*.login"
               onchange="location.href = '#{dev_support_path :action=>:set_current_user}&login=' + encodeURIComponent(this.options[this.selectedIndex].value)"
               selected="#{current_user.login}"
               class="dev-user-changer"
               merge-attrs/>
</def>

I'm not sure how the general case should be handled.
Besides that minor issue, a fantastic gem!

In my signup-form, the actions aren't getting the form-actions class added. It's getting the form-horizontal class, so I have no idea why form-actions isn't getting added. I spent some time looking into it, but didn't figure it out.

https://github.com/maxim/bootswatch-rails

depends on a different sassification of bootstrap, so doesn't apply easily. Supporting it or something like it would be nifty.

bootstrap-fields assigns a required class to required fields, but doesn't actually style anything with it. Not sure how we want to do it, but we should do something.

Bryan Larsen suggested to divide the code between "replaces jquery-ui" and "complements jquery-ui". I think this a great idea: https://groups.google.com/forum/?fromgroups#!topic/hobousers/MPvNX8WzQIU

Bug reported in Hobo Users by Bob Sleys:

Footers added via the footer tag in an extended page tag (example below) are sometimes outside the container bootstrap-content div tag and sometimes inside of it. IE it's outside the div on index, edit, new pages but inside on show pages.

<extend tag="page">
<old-page merge >
   <footer:><hr/>
    Copyright  <%= Time.now.year %>
        <a href="&admin_users_url" if="&current_user.administrator?">
        <br/>
        <t key="hobo.admin.subsite_name">Admin</t>
      </a>
    </footer:>
</old-page>
</extend>

In the table that shows up on index pages the actions buttons include the delete button even if the user doesn't have destroy permissions on the model.

Hobo/hobo#7

After this commit: d4de7e2

The delete icons have stopped working for me. I have not reproduced this in a clean environment yet.

We're using compass-twitter-bootstrap to provide the main twitter CSS, but we've included the responsive stuff ourselves. This means we have to keep it up to date ourselves, and it means that people can't choose their twitter version manually in their Gemfile like I suggest here: https://groups.google.com/d/msg/hobousers/44R5KhamYqU/IrSjChthvmUJ

hobo_bootstrap is getting big enough that it would be nice if the taglibs were nicely organized, à la Hobo Rapid.

aka: multiple subdirectories denoting 'sections'. Each directory has a simlarly named DRYML file, the first comment of which becomes the "section documentation introduction". Each tag is placed in its own file in a subdirectory, where the tag-name used for the filename.

suggestions for sections:

page, nav: these two sections are the theme proper
style (?): this section contains all the tags/extends that exist mostly just to add new classes to existing tags
forms, ...: sections that contain enhanced functionality

regardless of whether we do the reorg or not, we need to ensure that all tags are documented, or deliberately undocumented via <%# nodoc. %> All tags/extends that just exist to add a class or two to an existing tag should be marked nodoc.

Line 54 of taglibs/login.dryml should read

      <if test="&forgot_password_url"><t key="hobo.support.or">or</t> <a href="&forgot_password_url" param="forgot-password"><t key="hobo.login.forgot_password">Forgot your password?</t></a></if>

to have the "or" translated as well, instead of the current version

      <if test="&forgot_password_url">or <a href="&forgot_password_url" param="forgot-password"><t key="hobo.login.forgot_password">Forgot your password?</t></a></if>

Sorry not to provide a proper pull request, I have a mess here with my current version for bootstrap 3.
But I will fix that soon and give back to the community.

The plugin index page uses some sort of heuristic to figure out what is the "summary" from the README. This is failing for hobo_bootstrap.

http://cookbook.hobocentral.net/api_plugins

The tags need documentation.

Tags that are simple extensions of Hobo tags to adjust class names etc should be marked with <!-- nodoc. --> so that they don't pollute the cookbook.

Every other tag should be properly documented. bootstrap-fields is the most glaring example.

If we hobofy dialog & a datepicker and do something about our dependence on jQuery-UI's show & hide then jQuery-UI can be made optional for Hobo.

https://groups.google.com/forum/#!search/Hobo$20Bootstrap$20%E2%80%94$20which$20version$20of$20Bootstrap$3F$20Updating$20to$20BS3$3F/hobousers/3m4QUTQn9qI/jTvQDlQGAwAJ

https://groups.google.com/forum/#!searchin/hobousers/datepicker|sort:date/hobousers/0eBz-C9Plr8/c5rV6BkuLEQJ

Funny things can happen: look at the "X" button on the aside :D

The current state of I18n in hobo_bootstrap is kind of hacky (see #6). It would be nice to review and make sure it is consistant with the rest of Hobo.

The controls that show up in <table-plus ...><control:/></table-plus> are not styled.

I have identified a couple of CSS problems with hobo_bootstrap's field lists. In my opinion, they don't look as good as they should:

• The uneditable-input class creates a icon in my browser that is a bit confusing for the user.
• When a field does not have any content, the alignment is wrong.

I'm going to try to address these issues and make a pull request. Does anyone know of any other case where field lists don't behave as expected? Thanks!

When I am trying to edit one field with the tag <editor> , if i dont change the content of the input and i click elsewhere the input doesn't disappear.

Right now "Search" is hard coded. Translate it with hobo.live_search.label

Hello,

I have problems with double words model names.

Here is peice of code causing the problem:
taglibs/index_page.dryml:16
New <%= model %>

model.to_s.downcase results in the following error:
...
Hobo::I18nError in Process_steps#index
wrong model name: "processstep" (extracted from translation key: "processstep.actions.new"). You might want to use the translate/t tag/method instead.

If "model.to_s.downcase" is changed to "model.to_s" everything works just fine.

Denis.