Does Hoa Core need the "files" load approach in Composer? about core HOT 14 CLOSED

Hello :-),

We need to load Hoa for at least the hoa:// protocol, which is used by several projects to ensure consistency along migrations of their project, so I am not likely to remove the files property of the composer.json file. However, since PHP7 has introduced the Throwable interface, we can remove the code retro-implementing PHP7 features. I will do that right now, it's going to be easy without no risk.

However, this answer is also correct: http://stackoverflow.com/a/31265607. We should have check the presence of the class.
Nevertheless, Propel will have a serious issue with PHP7. You might open another issue to Propel to prepare them to PHP7.

from core.

Thanks @Hywan, that's splendid.

Yes, Propel 1 is quite old, and is shortly to be superceded by Propel 2, which is in alpha5 status presently. This will resolve the problem, since it will be fully namespaced.

from core.

@halfer Please, could you retry with hoa/core: 2.*@dev? If the problem is solved for you, then I will create a new snapshot.

from core.

Great, works for me @Hywan! Thanks for your speedy assistance.

from core.

@halfer https://github.com/hoaproject/Core/releases/tag/2.15.07.07

from core.

Will switch to that. 😸

from core.

@halfer: hoa/dev: ~2.0 will do the trick naturally.

from core.

Sorry for this bug with Propel :-(.

from core.

Thanks for coming over to Stack Overflow to report the fix. I've added an extra bounty to your answer, to get you started if you fancy asking/answering more questions.

from core.

@halfer Thanks!

from core.

However, this answer is also correct: http://stackoverflow.com/a/31265607. We should have check the presence of the class.

So why not add && false === interface_exists('Throwable', false) on https://github.com/hoaproject/Core/blob/master/Consistency.php#L944 ?

from core.

Because it forces other projects to be compatible with incoming PHP7 versions?

from core.

But if an other project do the same as you did it will result a conflict, since both only check the PHP version.

from core.

@Metalaka Correct 😉. Who want to make a PR?

from core.