Enhanced Hoa\Iterator API about central HOT 5 OPEN

this seems nice, it's always a PITA to come working with iterator in php back from rust (or javascript with lodash)

• find(Callable): mixed search the first item matching the predicate,
• position(Callable): mixed search the first item matching the predicate and returns in index,
• rightPosition(Callable): mixed same as position but searches from the right (the end) of the iterator,
• max(): int to get the maximum value of an iterator, will be based on the spaceship operator,
• min(): int to get the minimum value of an iterator, same mechanism than max,
  sum(): int to sum all elements in an iterator, this is a shortcut to fold with a special callable,
  product(): int to multiply all elements in an iterator, this is a shortcut to fold with a special callable,

shouldn't those return Options ? (not really sure about the last 2)

from central.

Note: This is somewhat very similar to nikic/iter cc @nikic if you have a feedback about your library (would you do something differently for instance? any performance issues?).

Main difference is that we are going to be full object instead of being functional.

from central.

@mathroc I guess sum and product must return 0 if the collection is empty. But max and min must return an option, correct! Them for find & co. I am fixing it. Thanks for the detailed look!

from central.

I'm ok for sum returning 0, however I'm not sure about product, I think it should return 1 (the identity element)

so that $a->product() * $b->product() === $a->chain($b)->product() is always true (as it is for sum)

from central.

You're correct! I reckon I should sleep more…

from central.