Code Monkey home page Code Monkey logo

Comments (17)

Hywan avatar Hywan commented on June 12, 2024

Hello :-),

First, there is no link between Rush Release and Composer.
Then, maybe: vendor/ instead of /vendor/ would be better. What about vendor/*, what's the difference between them?

Also, should we add IDE/editors files, such as:

  • *.swp for Vim,
  • #… for Emacs,
  • etc.

Do we assume users will use Vim, Emacs, PHPStorm and SublimeText to contribute? If yes, then we can use this gitignore file: https://www.gitignore.io/api/composer,vim,emacs,phpstorm,sublimetext.

Whilst gitignore.io seems to provide an exhaustive .gitignore file, what if we would like to add a new editor? We will have to patch all the .gitignore file. Is it an issue?

Thoughts? Should we git-ignore only Composer or also IDE and editors @hoaproject/hoackers?

from central.

QuingKhaos avatar QuingKhaos commented on June 12, 2024

Only ignore project specific stuff, such composer. Never clutter .gitignore with IDE stuff. For IDE files users MUST HAVE a gitignore global file. https://help.github.com/articles/ignoring-files/#create-a-global-gitignore

from central.

Hywan avatar Hywan commented on June 12, 2024

@patkar Agree with this.

from central.

jubianchi avatar jubianchi commented on June 12, 2024

@patkar +1

@Hywan

  • vendor/ and vendor/* will produce the same result
  • /vendor/ might be better as it will cause git to only ignore the vendor directory in the root of the repository. vendor/ will ignore it everywhere in the repo.

from central.

Hywan avatar Hywan commented on June 12, 2024

@jubianchi Thanks.
@shulard So… let's go with your proposal. Seems good for 👍!

from central.

Hywan avatar Hywan commented on June 12, 2024

@shulard What we used to do in this case is: Creating one issue per repository, with a link to this one. In this case, this issue will be a meta issue and will help to track the work. Then, you will have to create one PR per repository with a “Fix #xxx” in its description, where “xxx” is the ID of the issue (not the meta issue). We will close this meta issue manually when everything will be done.

from central.

Hywan avatar Hywan commented on June 12, 2024

@shulard Oh, and before creating PR for all repositories, let's try with one. Then we will review it, and after that, it will be the same work for all libraries 😃.

from central.

shulard avatar shulard commented on June 12, 2024

Hello,

Ok, I'll create the first PR. Maybe we should list all the repos that must be updated with that file.

from central.

Hywan avatar Hywan commented on June 12, 2024

@shulard Every library listed here: http://hoa-project.net/.

from central.

shulard avatar shulard commented on June 12, 2024

Oki 😄

from central.

Hywan avatar Hywan commented on June 12, 2024

I just updated the description of this issue to include the progression.

from central.

Hywan avatar Hywan commented on June 12, 2024

@shulard Check the checkboxes only when merged.

from central.

shulard avatar shulard commented on June 12, 2024

All the PRs have been created 😅

Sorry for the firsts, I mentioned the issue in the commit and in the PR...

from central.

Hywan avatar Hywan commented on June 12, 2024

Good work 👍!
I will try to merge everything after the lunch 😄!

from central.

Hywan avatar Hywan commented on June 12, 2024

Excellent work. Everything has been merged. Thank you very much 👍!

from central.

Hywan avatar Hywan commented on June 12, 2024

It just destroys the statistics of the week, haha:

stats

from central.

shulard avatar shulard commented on June 12, 2024

The same for my contribution graph 😄

from central.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.