Code Monkey home page Code Monkey logo

Comments (6)

edavis avatar edavis commented on May 30, 2024

Interesting. The NYT produces a bad feed nine years ago and we're still living with the consequences :)

So right now Thunderbird and Feedly use the URL in <guid> instead of the URL in <link>? And you'd like for an option to enable isPermalink=false on <guid> so they use <link> instead?

Out of curiosity, how does ?link=comments fix it? That just makes the values of <link> and <guid> equal.

FWIW, I'm not opposed to making this change if it helps improve the feed.

from hnrss.

Zweihander-Main avatar Zweihander-Main commented on May 30, 2024

Yup, that's exactly right. They're ignoring the <link> as they're assuming <guid> is set to true - if you add isPermalink=false to <guid>, they should use the <link> instead.

You can see it in action on Thunderbird--

Using news.ycombinator.com/rss (which doesn't have a guid):
image

Using hnrss:
image

Using hnrss with ?link=comments:
image

?link=comments alleviates it by still keeping the direct link on the page. It only falls short for certain workflows such as using keyboard shortcuts to open an item's 'Website' link in Thunderbird (and possibly Feedly if they have a similar shortcuts).

In Feedly, the ?link=comments feed with an item's "Visit Website" or title hovered over looks like:
image

Also for reference, here's what a link with 'isPermalink=false' set looks like in Thunderbird:
image

That's from http://blog.acolyer.org/feed/ which has a different <guid> than <link> (though both evaluate to the same address).

Definitely not a critical bug but thanks for taking a look at it!

from hnrss.

edavis avatar edavis commented on May 30, 2024

Hey @Zweihander42 — Haven't forgot about ya! Just haven't had the time to dig into this yet.

Great examples, too. Very helpful. I hope to spend some time on this soon.

Thanks again.

from hnrss.

edavis avatar edavis commented on May 30, 2024

@Zweihander42 — Not exactly the quickest turnaround, but this is now live :)

I went with setting isPermaLink="false" unconditionally because I think it just makes more sense than making it optional.

If RSS feeds hosted on Wordpress.com set that attribute unconditionally, we're probably in the clear. I'm sure they thoroughly researched the pros/cons and decided it was worth it.

Let me know if this clears up your Thunderbird issue.

Have a great day!

from hnrss.

Zweihander-Main avatar Zweihander-Main commented on May 30, 2024

@edavis -- Works as expected!

Thunderbird and Feedly both look good:
image

and with title hovered over:
image

Thanks so much, appreciate it!

from hnrss.

edavis avatar edavis commented on May 30, 2024

Happy to help!

from hnrss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.