Better checking when to show a page, and when to show links to a page about publicdb HOT 8 CLOSED

What links point back to the 404? This should indeed not happen. Moreover, the missing Summary object should be handled more gracefully.

from publicdb.

In commits 0ff6d36 and 9ecc379 I have tried to improve on this, to make sure we don't provide links to pages that will fail because of missing Summary objects (or rather; because of existing Summary objects related to days without any data).

Mainly by adding this to filters; Q(num_events__isnull=False) | Q(num_weather__isnull=False)
And additionally to some I added; date__gte=datetime.date(2002, 1, 1), date__lte=datetime.date.today()
To prevent linking to future dates and to before we started this.

In case it does happen, it would be nice If we have a better 404 page redirecting people back to the homepage.

from publicdb.

In the view, something like this?

try:
    Summary.objects.get(date)
except Summary.DoesNotExist:
    return render_to_response('there_is_no_data_on_this_day.html')
else:
    foo()
    return render_to_response('data_pagina.html')

from publicdb.

Hmm, that might indeed be a good addition, even if we dont link to dates without data, people might edit links themselves.
A similar check could be done for the station id. And then we could also add one for the status page of in active stations.. etc..
But this might get to convoluted, it would be nice, but would a general (but specific to our site) 404 page not be sufficient?

from publicdb.

I was a bit short in my code. The Summary is linked to the station and a specific date. And you have to check for events; there might only be error messages on a particular day. The error page can be more general, but I'd like to have some separation between:

data.hisparc.nl/foo/bar/baz/ -> 404 (url not found)
data.hisparc.nl/show/station/501/2012/04/18 -> 404 (no data)

from publicdb.

Should we then also have;
data.hisparc.nl/django/show/station/555/[date] -> 404 (no station)
data.hisparc.nl/django/show/station/10001/status -> 404 (not active)
data.hisparc.nl/django/show/station/10001/config -> 404 (no config)

I do agree that there should be a difference between a 404 from a bad url pattern and from missing data and such.

from publicdb.

General 403, 404 and 500 pages made in commit aea6b73

from publicdb.

Almost all broken links are gone.
500 errors get reported and fixed quick enough.
404 errors might need to be monitored a bit more to fix remaining broken links.
But good enough for now, closing.

from publicdb.