thread-safe access to `Index` about alexandrie HOT 2 OPEN

no problem! it also lifts the restriction that all the methods in the Indexer trait should take &self. Being able to take &mut self allows implementors of Index to avoid using interior mutability to modify themselves.

from alexandrie.

Yes, the Mutex in Git2Index was indeed to have it be Sync.
At the time, I thought it would be fine but you made very good points about how that lock is not actually useful and how having it Sync is not accurate. I didn't realize that and that's completely on me.
I am sold on removing the lock from there and using an Arc<Mutex<config::State>> as Tide's state.
Thank you for pointing that out, that is quite a big deal and could easily lead to consistency issues in the registry's state.

from alexandrie.